You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/07/29 05:44:14 UTC
[GitHub] [hudi] nsivabalan opened a new pull request, #6239: [HUDI-4501] Throwing exception when restore is attempted with hoodie.arhive.beyond.savepoint is enabled
nsivabalan opened a new pull request, #6239:
URL: https://github.com/apache/hudi/pull/6239
## What is the purpose of the pull request
When "hoodie.archive.beyond.savepoint" is enabled, we can't support "restore" as there could be holes in the timeline. We have a [jira](https://issues.apache.org/jira/browse/HUDI-4500) to fix it properly. Until then, we need to throw exception when restore is attempted.
## Brief change log
- Failing restore in BaseHoodieWriteClient when "hoodie.archive.beyond.savepoint" is enabled.
## Verify this pull request
- TestHoodieClientOnCopyOnWriteStorage#testRestoreWithSavepointBeyondArchival
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6239: [HUDI-4501] Throwing exception when restore is attempted with hoodie.arhive.beyond.savepoint is enabled
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6239:
URL: https://github.com/apache/hudi/pull/6239#issuecomment-1201542220
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b1a3c6eb8bbabf29e95a20d866b9a3c83681ad48",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10444",
"triggerID" : "b1a3c6eb8bbabf29e95a20d866b9a3c83681ad48",
"triggerType" : "PUSH"
}, {
"hash" : "bff48a42c6a9c10715dc0b2b4958cd2b904ec82d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10506",
"triggerID" : "bff48a42c6a9c10715dc0b2b4958cd2b904ec82d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b1a3c6eb8bbabf29e95a20d866b9a3c83681ad48 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10444)
* bff48a42c6a9c10715dc0b2b4958cd2b904ec82d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10506)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6239: [HUDI-4501] Throwing exception when restore is attempted with hoodie.arhive.beyond.savepoint is enabled
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6239:
URL: https://github.com/apache/hudi/pull/6239#issuecomment-1198954033
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b1a3c6eb8bbabf29e95a20d866b9a3c83681ad48",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10444",
"triggerID" : "b1a3c6eb8bbabf29e95a20d866b9a3c83681ad48",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b1a3c6eb8bbabf29e95a20d866b9a3c83681ad48 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10444)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #6239: [HUDI-4501] Throwing exception when restore is attempted with hoodie.arhive.beyond.savepoint is enabled
Posted by GitBox <gi...@apache.org>.
nsivabalan merged PR #6239:
URL: https://github.com/apache/hudi/pull/6239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6239: [HUDI-4501] Throwing exception when restore is attempted with hoodie.arhive.beyond.savepoint is enabled
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6239:
URL: https://github.com/apache/hudi/pull/6239#issuecomment-1202750784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b1a3c6eb8bbabf29e95a20d866b9a3c83681ad48",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10444",
"triggerID" : "b1a3c6eb8bbabf29e95a20d866b9a3c83681ad48",
"triggerType" : "PUSH"
}, {
"hash" : "bff48a42c6a9c10715dc0b2b4958cd2b904ec82d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10506",
"triggerID" : "bff48a42c6a9c10715dc0b2b4958cd2b904ec82d",
"triggerType" : "PUSH"
}, {
"hash" : "7df35ac1c98d2aa8c95e42ab00c1fe514997df1a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10523",
"triggerID" : "7df35ac1c98d2aa8c95e42ab00c1fe514997df1a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bff48a42c6a9c10715dc0b2b4958cd2b904ec82d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10506)
* 7df35ac1c98d2aa8c95e42ab00c1fe514997df1a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10523)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a diff in pull request #6239: [HUDI-4501] Throwing exception when restore is attempted with hoodie.arhive.beyond.savepoint is enabled
Posted by GitBox <gi...@apache.org>.
codope commented on code in PR #6239:
URL: https://github.com/apache/hudi/pull/6239#discussion_r933077438
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -2447,6 +2447,11 @@ public Builder withAllowMultiWriteOnSameInstant(boolean allow) {
return this;
}
+ public Builder withArchiveBeyondSavepoint(boolean allow) {
Review Comment:
Would be preferable to have single builder method for this config. Can't we reuse the one in `HoodieArchivalConfig`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6239: [HUDI-4501] Throwing exception when restore is attempted with hoodie.arhive.beyond.savepoint is enabled
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6239:
URL: https://github.com/apache/hudi/pull/6239#issuecomment-1202983073
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b1a3c6eb8bbabf29e95a20d866b9a3c83681ad48",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10444",
"triggerID" : "b1a3c6eb8bbabf29e95a20d866b9a3c83681ad48",
"triggerType" : "PUSH"
}, {
"hash" : "bff48a42c6a9c10715dc0b2b4958cd2b904ec82d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10506",
"triggerID" : "bff48a42c6a9c10715dc0b2b4958cd2b904ec82d",
"triggerType" : "PUSH"
}, {
"hash" : "7df35ac1c98d2aa8c95e42ab00c1fe514997df1a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10523",
"triggerID" : "7df35ac1c98d2aa8c95e42ab00c1fe514997df1a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7df35ac1c98d2aa8c95e42ab00c1fe514997df1a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10523)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6239: [HUDI-4501] Throwing exception when restore is attempted with hoodie.arhive.beyond.savepoint is enabled
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6239:
URL: https://github.com/apache/hudi/pull/6239#issuecomment-1201622816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b1a3c6eb8bbabf29e95a20d866b9a3c83681ad48",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10444",
"triggerID" : "b1a3c6eb8bbabf29e95a20d866b9a3c83681ad48",
"triggerType" : "PUSH"
}, {
"hash" : "bff48a42c6a9c10715dc0b2b4958cd2b904ec82d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10506",
"triggerID" : "bff48a42c6a9c10715dc0b2b4958cd2b904ec82d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bff48a42c6a9c10715dc0b2b4958cd2b904ec82d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10506)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6239: [HUDI-4501] Throwing exception when restore is attempted with hoodie.arhive.beyond.savepoint is enabled
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6239:
URL: https://github.com/apache/hudi/pull/6239#issuecomment-1198910078
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b1a3c6eb8bbabf29e95a20d866b9a3c83681ad48",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10444",
"triggerID" : "b1a3c6eb8bbabf29e95a20d866b9a3c83681ad48",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b1a3c6eb8bbabf29e95a20d866b9a3c83681ad48 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10444)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6239: [HUDI-4501] Throwing exception when restore is attempted with hoodie.arhive.beyond.savepoint is enabled
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6239:
URL: https://github.com/apache/hudi/pull/6239#issuecomment-1198907872
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b1a3c6eb8bbabf29e95a20d866b9a3c83681ad48",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b1a3c6eb8bbabf29e95a20d866b9a3c83681ad48",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b1a3c6eb8bbabf29e95a20d866b9a3c83681ad48 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6239: [HUDI-4501] Throwing exception when restore is attempted with hoodie.arhive.beyond.savepoint is enabled
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6239:
URL: https://github.com/apache/hudi/pull/6239#issuecomment-1202738770
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b1a3c6eb8bbabf29e95a20d866b9a3c83681ad48",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10444",
"triggerID" : "b1a3c6eb8bbabf29e95a20d866b9a3c83681ad48",
"triggerType" : "PUSH"
}, {
"hash" : "bff48a42c6a9c10715dc0b2b4958cd2b904ec82d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10506",
"triggerID" : "bff48a42c6a9c10715dc0b2b4958cd2b904ec82d",
"triggerType" : "PUSH"
}, {
"hash" : "7df35ac1c98d2aa8c95e42ab00c1fe514997df1a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7df35ac1c98d2aa8c95e42ab00c1fe514997df1a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bff48a42c6a9c10715dc0b2b4958cd2b904ec82d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10506)
* 7df35ac1c98d2aa8c95e42ab00c1fe514997df1a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6239: [HUDI-4501] Throwing exception when restore is attempted with hoodie.arhive.beyond.savepoint is enabled
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6239:
URL: https://github.com/apache/hudi/pull/6239#issuecomment-1201536523
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b1a3c6eb8bbabf29e95a20d866b9a3c83681ad48",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10444",
"triggerID" : "b1a3c6eb8bbabf29e95a20d866b9a3c83681ad48",
"triggerType" : "PUSH"
}, {
"hash" : "bff48a42c6a9c10715dc0b2b4958cd2b904ec82d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bff48a42c6a9c10715dc0b2b4958cd2b904ec82d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b1a3c6eb8bbabf29e95a20d866b9a3c83681ad48 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10444)
* bff48a42c6a9c10715dc0b2b4958cd2b904ec82d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org