[jira] [Work logged] (BEAM-13250) GCSFileSystem is not facilitating injection of the gcs url

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-13250?focusedWorklogId=761385&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-761385 ]

ASF GitHub Bot logged work on BEAM-13250:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Apr/22 02:59
            Start Date: 24/Apr/22 02:59
    Worklog Time Spent: 10m 
      Work Description: asf-ci commented on PR #17455:
URL: https://github.com/apache/beam/pull/17455#issuecomment-1107693153

   Can one of the admins verify this patch?




Issue Time Tracking
-------------------

    Worklog Id:     (was: 761385)
    Time Spent: 2.5h  (was: 2h 20m)

> GCSFileSystem is not facilitating injection of the gcs url
> ----------------------------------------------------------
>
>                 Key: BEAM-13250
>                 URL: https://issues.apache.org/jira/browse/BEAM-13250
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-py-gcp
>    Affects Versions: 2.33.0
>            Reporter: Mathieu Leduc-Hamel
>            Priority: P2
>             Fix For: Not applicable
>
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Inside `apache_beam.io.gcp.gcsfilesystem.GCSFileSystem` is directly instantiating for every operations an instance of `apache_beam.io.gcp.gcsio.GcsIO` without allowing anyone to make use of the flexibility of instantiating with a custom client storage.
> As you can see inside `GcsIO` there's an optional parameter called `storage_client` and that would give us the possibility to overwrite the storage client by example depending of the run level and potentially make use of a Gcs emulator locally when testing the infrastructure.
> Right now the only way we have to overwrite the gcs url is by monkey patching the default storage which is not most clean way of doing it.
>  
> Potential solution:
> If `GCSFileSystem` was transformed by example by adding a single class method to generate every one of thse `GcsIO`, that would give us the possibility to create a custom `GCSFileSystem` class, inheriting from it, without duplicating all of it's code and to inject our desired url depending of the run level.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)