You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by kfeagle <gi...@git.apache.org> on 2017/04/10 05:07:50 UTC
[GitHub] incubator-weex pull request #238: * [ios] change keyboard event to keybord a...
GitHub user kfeagle opened a pull request:
https://github.com/apache/incubator-weex/pull/238
* [ios] change keyboard event to keybord and add animation for Navig\u2026
* [ios] change keyboard event to keybord and add animation for navigationBarHidden
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kfeagle/incubator-weex ios-bugfix-navigation-0.12-dev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/238.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #238
----
commit 917ca2ab26ab9206aaa37d55ebdd503883b55627
Author: \u9f50\u5c71 <su...@163.com>
Date: 2017-04-10T05:06:46Z
* [ios] change keyboard event to keybord and add animation for NavigationBarHidden [self.navigationController setNavigationBarHidden:YES animated:YES];
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #238: * [ios] change keyboard event to keybord a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/238
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #238: * [ios] change keyboard event to keybord a...
Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/238#discussion_r110578080
--- Diff: ios/sdk/WeexSDK/Sources/Controller/WXBaseViewController.m ---
@@ -70,10 +70,10 @@ - (void)viewDidLoad
self.view.backgroundColor = [UIColor whiteColor];
self.automaticallyAdjustsScrollViewInsets = NO;
[self _renderWithURL:_sourceURL];
-
if ([self.navigationController isKindOfClass:[WXRootViewController class]]) {
- self.navigationController.navigationBarHidden = YES;
--- End diff --
@boboning animating ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---