You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by "Mathieu Lirzin (JIRA)" <ji...@apache.org> on 2019/05/15 07:46:00 UTC

[jira] [Commented] (OFBIZ-11032) ServiceDispatcher implementation details should be private

    [ https://issues.apache.org/jira/browse/OFBIZ-11032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840128#comment-16840128 ] 

Mathieu Lirzin commented on OFBIZ-11032:
----------------------------------------

I will wait a couple of days for comments before committing [^OFBIZ-11032_ServiceDispatcher-is-not-meant-to-be-extend.patch].

> ServiceDispatcher implementation details should be private
> ----------------------------------------------------------
>
>                 Key: OFBIZ-11032
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11032
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Assignee: Mathieu Lirzin
>            Priority: Minor
>         Attachments: OFBIZ-11032_ServiceDispatcher-is-not-meant-to-be-extend.patch
>
>
> The {{protected}} modifier is used for the ServiceDispatcher in place of {{private}}. Since the {{ServiceDispatcher}} is not meant to be extended by plugins it is not desirable to use the {{protected}} modifier.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)