[jira] [Commented] (IGNITE-5011) Add validation of input params of disco command

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999385#comment-15999385 ] 

ASF GitHub Bot commented on IGNITE-5011:
----------------------------------------

GitHub user vinx13 opened a pull request:

    https://github.com/apache/ignite/pull/1917

    IGNITE-5011: Add validation on args and show proper warnings on disco command

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vinx13/ignite ignite-5011

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/1917.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1917
    
----
commit a3230f6f92622a2cadbc0a1e3c0748685a2c4aed
Author: Wuwei Lin <vi...@gmail.com>
Date:   2017-05-06T10:37:32Z

    IGNITE-5011: Add validation on args and show proper warnings

----


> Add validation of input params of disco command
> -----------------------------------------------
>
>                 Key: IGNITE-5011
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5011
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Pavel Konstantinov
>            Assignee: Wuwei Lin
>            Priority: Trivial
>
> {code}
> visor> disco -t=0h
> java.lang.IllegalArgumentException: Time frame size is not positive in: 0h
>         at org.apache.ignite.visor.visor$.timeFilter(visor.scala:2671)
>         at org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand.disco(VisorDiscoveryCommand.scala:127)
>         at org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand$$anonfun$4.apply(VisorDiscoveryCommand.scala:282)
>         at org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand$$anonfun$4.apply(VisorDiscoveryCommand.scala:282)
>         at org.apache.ignite.visor.commands.VisorConsole.mainLoop(VisorConsole.scala:217)
>         at org.apache.ignite.visor.commands.VisorConsole$.delayedEndpoint$org$apache$ignite$visor$commands$VisorConsole$1(VisorConsole.scala:329)
>         at org.apache.ignite.visor.commands.VisorConsole$delayedInit$body.apply(VisorConsole.scala:318)
>         at scala.Function0$class.apply$mcV$sp(Function0.scala:34)
>         at scala.runtime.AbstractFunction0.apply$mcV$sp(AbstractFunction0.scala:12)
>         at scala.App$$anonfun$main$1.apply(App.scala:76)
>         at scala.App$$anonfun$main$1.apply(App.scala:76)
>         at scala.collection.immutable.List.foreach(List.scala:381)
>         at scala.collection.generic.TraversableForwarder$class.foreach(TraversableForwarder.scala:35)
>         at scala.App$class.main(App.scala:76)
>         at org.apache.ignite.visor.commands.VisorConsole$.main(VisorConsole.scala:318)
>         at org.apache.ignite.visor.commands.VisorConsole.main(VisorConsole.scala)
> (wrn) <visor>: Invalid command name: 'disco -t=0h'
> (wrn) <visor>: Type 'help' to print commands list.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)