[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3188: ARTEMIS-2807 avoid notifications on critical IO error

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #3188:
URL: https://github.com/apache/activemq-artemis/pull/3188#discussion_r441724036



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
##########
@@ -1071,6 +1071,11 @@ void stop(boolean failoverOnServerShutdown, final boolean criticalIOError, boole
          }
          state = SERVER_STATE.STOPPING;
 
+         if (criticalIOError) {
+            // notifications trigger disk IO so we don't want to send any on a critical IO error

Review comment:
       I agree with this change.
   
   Although I think we could follow up with an option to HALT on critical IO like we do on the critical analyzer. (not just shutdown).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org