You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/14 02:39:17 UTC

[GitHub] [flink] lincoln-lil commented on pull request #20745: [FLINK-28988] Don't push above filters down into the right table for temporal join

lincoln-lil commented on PR #20745:
URL: https://github.com/apache/flink/pull/20745#issuecomment-1312961086

   @shuiqiangchen I found this pr while combing through the list of sql related legacy issues, and recently we fixed another similar user case on event time temporal join in FLINK-29849 includes two problems: 1. ChangelogNormalize incorrectly added for upsert source; 2. incorrectly filter pushdown
   and for the second one, I think your solution that only prevent pushing down filter related to the right side of input for the event time temporal join is better,
   would you like continue this work and fixing the failed tests first？And after this was done, the pr for FLINK-29849 can remove the filter part and based on your fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org