You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by yo...@apache.org on 2022/09/14 11:04:11 UTC

[superset] branch master updated: fix: hide time_grain when x_axis value is undefined (#21464)

This is an automated email from the ASF dual-hosted git repository.

yongjiezhao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new ae6d2cf18d fix: hide time_grain when x_axis value is undefined (#21464)
ae6d2cf18d is described below

commit ae6d2cf18dbf0fec78e577b0cad1881940796b50
Author: Yongjie Zhao <yo...@gmail.com>
AuthorDate: Wed Sep 14 19:03:49 2022 +0800

    fix: hide time_grain when x_axis value is undefined (#21464)
---
 .../packages/superset-ui-chart-controls/src/shared-controls/index.tsx   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/index.tsx b/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/index.tsx
index 27925a52f0..d46606e6be 100644
--- a/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/index.tsx
+++ b/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/index.tsx
@@ -332,7 +332,7 @@ const time_grain_sqla: SharedControlConfig<'SelectControl'> = {
 
     const xAxis = controls?.x_axis;
     const xAxisValue = xAxis?.value;
-    if (xAxisValue === undefined || isAdhocColumn(xAxisValue)) {
+    if (isAdhocColumn(xAxisValue)) {
       return true;
     }
     if (isPhysicalColumn(xAxisValue)) {