You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "nabarun (JIRA)" <ji...@apache.org> on 2018/10/03 21:38:42 UTC
[jira] [Closed] (GEODE-5346) Fix race in
LauncherLifecycleCommandsDUnitTest
[ https://issues.apache.org/jira/browse/GEODE-5346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nabarun closed GEODE-5346.
--------------------------
> Fix race in LauncherLifecycleCommandsDUnitTest
> ----------------------------------------------
>
> Key: GEODE-5346
> URL: https://issues.apache.org/jira/browse/GEODE-5346
> Project: Geode
> Issue Type: Bug
> Components: gfsh, management
> Reporter: Jens Deppe
> Assignee: Jens Deppe
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Errors such as the following sometimes occur:
> {noformat}
> org.apache.geode.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest > testVersionTitleForStartServerAndLocator FAILED
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at org.apache.geode.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest.readPid(LauncherLifecycleCommandsDUnitTest.java:195)
> at org.apache.geode.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest.waitForGemFireProcessToStop(LauncherLifecycleCommandsDUnitTest.java:260)
> at org.apache.geode.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest.stopServer(LauncherLifecycleCommandsDUnitTest.java:237)
> at org.apache.geode.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest.testVersionTitleForStartServerAndLocator(LauncherLifecycleCommandsDUnitTest.java:449){noformat}
>
> Fix a race where we wait for a component to stop by calling {{stop()}} and then waiting for the pid to disappear. The stop action happens in a different thread so the pid may disappear before the checking thread actually gets to check it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)