You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/08/28 14:10:22 UTC

[GitHub] [incubator-yunikorn-core] sunilgovind commented on pull request #198: [WIP][YUNIKORN-366] Add rest API to update queue configuration

sunilgovind commented on pull request #198:
URL: https://github.com/apache/incubator-yunikorn-core/pull/198#issuecomment-682597245


   I think this makes sense to have either one of the option to be enabled in YK.
   1. Via configmap hot refresh
   2. Via UpdateConf REST API
   At the time when we are expecting to have the config update from rest api, its always gonna be a mess and complex to watch for configmap (some one could edit via kube apis). And as a system, we will be patching holes all around.
   
   I am not seeing a major reason to support both together. So +1 to this approach.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org