You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/15 10:48:16 UTC

[GitHub] [airflow] ashb commented on a change in pull request #21301: Introduce 'Callbacks Sink' classes for sending callbacks

ashb commented on a change in pull request #21301:
URL: https://github.com/apache/airflow/pull/21301#discussion_r806697988



##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -48,7 +49,7 @@
 from airflow.stats import Stats
 from airflow.ti_deps.dependencies_states import EXECUTION_STATES
 from airflow.utils import timezone
-from airflow.utils.callback_requests import DagCallbackRequest, TaskCallbackRequest
+from airflow.utils.callback_requests import DagCallbackRequest, SlaCallbackRequest, TaskCallbackRequest

Review comment:
       Let's move this out of `airflow.utils` and in to `airflow.callbacks` as utils is a huge messy dumping ground.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org