You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/13 09:32:58 UTC
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request
#5162: SPI for complex algorithm
tristaZero opened a new pull request #5162: SPI for complex algorithm
URL: https://github.com/apache/incubator-shardingsphere/pull/5162
Ref #5017.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#5162: SPI for complex algorithm
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #5162: SPI for complex algorithm
URL: https://github.com/apache/incubator-shardingsphere/pull/5162#issuecomment-612836208
## Pull Request Test Coverage Report for [Build 11009](https://coveralls.io/builds/30038364)
* **14** of **15** **(93.33%)** changed or added relevant lines in **2** files are covered.
* **26** unchanged lines in **2** files lost coverage.
* Overall coverage decreased (**-0.04%**) to **57.615%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/yaml/swapper/ShardingStrategyConfigurationYamlSwapper.java](https://coveralls.io/builds/30038364/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fyaml%2Fswapper%2FShardingStrategyConfigurationYamlSwapper.java#L152) | 12 | 13 | 92.31%
<!-- | **Total:** | **14** | **15** | **93.33%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/controller/task/SyncTaskControlStatus.java](https://coveralls.io/builds/30038364/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fcontroller%2Ftask%2FSyncTaskControlStatus.java#L68) | 1 | 0% |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/controller/ScalingJobController.java](https://coveralls.io/builds/30038364/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fcontroller%2FScalingJobController.java#L39) | 25 | 0% |
<!-- | **Total:** | **26** | | -->
| Totals | [](https://coveralls.io/builds/30038364) |
| :-- | --: |
| Change from base [Build 10995](https://coveralls.io/builds/30030468): | -0.04% |
| Covered Lines: | 11822 |
| Relevant Lines: | 20519 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #5162: SPI
for complex algorithm
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #5162: SPI for complex algorithm
URL: https://github.com/apache/incubator-shardingsphere/pull/5162
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5162: SPI
for complex algorithm
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #5162: SPI for complex algorithm
URL: https://github.com/apache/incubator-shardingsphere/pull/5162#issuecomment-612835324
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5162?src=pr&el=h1) Report
> Merging [#5162](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5162?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/e0f110fe0de085c85a319b5a1e685732aebe2abc&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `86.66%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5162?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5162 +/- ##
============================================
+ Coverage 54.23% 54.25% +0.01%
Complexity 406 406
============================================
Files 1156 1157 +1
Lines 20502 20514 +12
Branches 3695 3696 +1
============================================
+ Hits 11120 11130 +10
- Misses 8694 8695 +1
- Partials 688 689 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5162?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...tegy/YamlComplexShardingStrategyConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5162/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL2NvbmZpZy9zaGFyZGluZy9zdHJhdGVneS9ZYW1sQ29tcGxleFNoYXJkaW5nU3RyYXRlZ3lDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...pper/ShardingStrategyConfigurationYamlSwapper.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5162/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL3N3YXBwZXIvU2hhcmRpbmdTdHJhdGVneUNvbmZpZ3VyYXRpb25ZYW1sU3dhcHBlci5qYXZh) | `95.38% <84.61%> (-2.80%)` | `0.00 <0.00> (ø)` | |
| [...g/strategy/YamlShardingAlgorithmConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5162/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL2NvbmZpZy9zaGFyZGluZy9zdHJhdGVneS9ZYW1sU2hhcmRpbmdBbGdvcml0aG1Db25maWd1cmF0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5162?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5162?src=pr&el=footer). Last update [e0f110f...d9b0ef6](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5162?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#5162: SPI for complex algorithm
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #5162: SPI for complex algorithm
URL: https://github.com/apache/incubator-shardingsphere/pull/5162#issuecomment-612836208
## Pull Request Test Coverage Report for [Build 10998](https://coveralls.io/builds/30035490)
* **14** of **15** **(93.33%)** changed or added relevant lines in **2** files are covered.
* **26** unchanged lines in **2** files lost coverage.
* Overall coverage decreased (**-0.04%**) to **57.615%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/yaml/swapper/ShardingStrategyConfigurationYamlSwapper.java](https://coveralls.io/builds/30035490/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fyaml%2Fswapper%2FShardingStrategyConfigurationYamlSwapper.java#L152) | 12 | 13 | 92.31%
<!-- | **Total:** | **14** | **15** | **93.33%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/controller/task/SyncTaskControlStatus.java](https://coveralls.io/builds/30035490/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fcontroller%2Ftask%2FSyncTaskControlStatus.java#L68) | 1 | 0% |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/controller/ScalingJobController.java](https://coveralls.io/builds/30035490/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fcontroller%2FScalingJobController.java#L39) | 25 | 0% |
<!-- | **Total:** | **26** | | -->
| Totals | [](https://coveralls.io/builds/30035490) |
| :-- | --: |
| Change from base [Build 10995](https://coveralls.io/builds/30030468): | -0.04% |
| Covered Lines: | 11822 |
| Relevant Lines: | 20519 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5162: SPI
for complex algorithm
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5162: SPI for complex algorithm
URL: https://github.com/apache/incubator-shardingsphere/pull/5162#issuecomment-612836208
## Pull Request Test Coverage Report for [Build 10997](https://coveralls.io/builds/30035054)
* **14** of **15** **(93.33%)** changed or added relevant lines in **2** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.02%**) to **57.678%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/yaml/swapper/ShardingStrategyConfigurationYamlSwapper.java](https://coveralls.io/builds/30035054/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fyaml%2Fswapper%2FShardingStrategyConfigurationYamlSwapper.java#L152) | 12 | 13 | 92.31%
<!-- | **Total:** | **14** | **15** | **93.33%** | -->
| Totals | [](https://coveralls.io/builds/30035054) |
| :-- | --: |
| Change from base [Build 10995](https://coveralls.io/builds/30030468): | 0.02% |
| Covered Lines: | 11832 |
| Relevant Lines: | 20514 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services