You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/09/30 19:09:46 UTC

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #6144: Document endpoint perms for role based permissions

ocket8888 commented on a change in pull request #6144:
URL: https://github.com/apache/trafficcontrol/pull/6144#discussion_r719685786



##########
File path: docs/source/api/v4/cdn_locks.rst
##########
@@ -71,6 +72,7 @@ Allows user to acquire a lock on a CDN.
 
 :Auth. Required: Yes
 :Roles Required: "admin" or "operations"
+:Permissions Required: CDNLOCK:CREATE

Review comment:
       Should things like this also require `CDN-READ` (or equivalent)? Like, a user is allowed to delete a CDN that they aren't allowed to know exists. But the information is exposed by being able to manipulate the objects anyway, and then if e.g. in this case, if the CDN is already locked and it returns an error like "CDN 'CDN-Name' is already locked" then should it check for Permissions before displaying the CDN name in the error message?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org