You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2021/10/10 09:20:06 UTC
[GitHub] [buildstream] gtristan opened a new pull request #1524: Revert to expecting '.bst' on the command line to disambiguate elements and artifacts
gtristan opened a new pull request #1524:
URL: https://github.com/apache/buildstream/pull/1524
Summary of changes:
* _stream.py: Treat targets with `.bst` suffixes as elements and other
targets as artifacts, and improve error reporting around this.
Also use a new machine readable error string to denote when we fail
to create a directory when creating a workspace.
* _loader/loader.py: Remove handling of LoadErrorReason.LOADING_DIRECTORY
This additional handling was only to suggest that maybe the user
meant to specify "<directory_name>.bst" in the case a directory is
encountered, but now we will bail out earlier if an element target
is specified without a ".bst" suffix anyway.
The only way to reach this error is to load a directory which itself
already has a ".bst" suffix, in which case the additional suggestion
is no longer useful.
* tests/format/elementnames.py: Expect different error for target elements
* tests/frontend/artifact_show.py: Removed test that is no longer relevant,
it is now impossible to glob for both elements and artifacts with the
same glob expression.
* tests/frontend/show.py: Removed some parameters of the glob test which
were expecting to get element results without specifying a ".bst" suffix
* tests/frontend/workspace.py: Specify a newly added machine readable reason
for the error of failing to create a directory while opening a workspace
* tests/internals/loader.py: Trigger the LoadErrorReason.LOADING_DIRECTORY
error by creating a directory named "element.bst", so that it gets by
the initial element name suffix checks.
Fixes #1411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan merged pull request #1524: Revert to expecting '.bst' on the command line to disambiguate elements and artifacts
Posted by GitBox <gi...@apache.org>.
gtristan merged pull request #1524:
URL: https://github.com/apache/buildstream/pull/1524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan edited a comment on pull request #1524: Revert to expecting '.bst' on the command line to disambiguate elements and artifacts
Posted by GitBox <gi...@apache.org>.
gtristan edited a comment on pull request #1524:
URL: https://github.com/apache/buildstream/pull/1524#issuecomment-939437474
~~Some documentation still needs to be amended before we can consider merging this.~~
This is done now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1524: Revert to expecting '.bst' on the command line to disambiguate elements and artifacts
Posted by GitBox <gi...@apache.org>.
gtristan commented on pull request #1524:
URL: https://github.com/apache/buildstream/pull/1524#issuecomment-939437474
Some documentation still needs to be amended before we can consider merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org