You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/19 03:06:54 UTC

[GitHub] [doris] Tanya-W commented on a diff in pull request #16075: [Feature-WIP](inverted index)(bkd) Support try query before query bkd to improve query efficiency

Tanya-W commented on code in PR #16075:
URL: https://github.com/apache/doris/pull/16075#discussion_r1080764943


##########
be/src/olap/rowset/segment_v2/inverted_index_reader.cpp:
##########
@@ -607,6 +639,15 @@ Status InvertedIndexIterator::try_read_from_inverted_index(const std::string& co
                                                            const void* query_value,
                                                            InvertedIndexQueryType query_type,
                                                            uint32_t* count) {
+    // NOTE: only bkd index support try read now.
+    if (query_type == InvertedIndexQueryType::GREATER_EQUAL_QUERY ||

Review Comment:
   yes, but i feel it's not necessary, match query type also has several types: MATCH_ANY_QUERY, MATCH_ALL_QUERY, MATCH_PHRASE_QUERY



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org