You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/04/08 04:35:48 UTC
Review Request 32957: Update widgets.json for HBase and add for HDFS
and YARN
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32957/
-----------------------------------------------------------
Review request for Ambari, Sid Wagle and Yusaku Sako.
Bugs: AMBARI-10393
https://issues.apache.org/jira/browse/AMBARI-10393
Repository: ambari
Description
-------
This includes updating HBase widgets.json and adding HDFS and YARN widgets.json files. These are default widget definitions which will be used to populate widget instances in ambari database on respective service resource creation (This will done with a seperate ticket).
Diffs
-----
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metrics.json 7bbf7be
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/widgets.json a64a2c8
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metrics.json 6fc808e
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json PRE-CREATION
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/widgets.json PRE-CREATION
Diff: https://reviews.apache.org/r/32957/diff/
Testing
-------
Manually Teseted the patch on cluster
Thanks,
Jaimin Jetly
Re: Review Request 32957: Update widgets.json for HBase and add for
HDFS and YARN
Posted by Jaimin Jetly <ja...@hortonworks.com>.
> On April 8, 2015, 6:56 a.m., Yusaku Sako wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/widgets.json, line 9
> > <https://reviews.apache.org/r/32957/diff/1/?file=920421#file920421line9>
> >
> > For this and other NodeManager metrics, shouldn't we just say NodeManager rather than YARN?
> > For example, "NodeManager Garbage Collection Time" rather than "YARN Garbage Collection Time".
Personally I agree that "Datanode instead of HDFS and NodeManager instead of YARN" is more accurate. But for all the heatmap I kept displayname same as we have right now hardcoded on UI (HDFS instead of datanode and YARN instaead of NodeManager). So there is no change in the look and feel of the heatmap page on upgrade from previous versions of ambari. I can do it other way which is more precise
- Jaimin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32957/#review79318
-----------------------------------------------------------
On April 8, 2015, 2:35 a.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32957/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 2:35 a.m.)
>
>
> Review request for Ambari, Sid Wagle and Yusaku Sako.
>
>
> Bugs: AMBARI-10393
> https://issues.apache.org/jira/browse/AMBARI-10393
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This includes updating HBase widgets.json and adding HDFS and YARN widgets.json files. These are default widget definitions which will be used to populate widget instances in ambari database on respective service resource creation (This will done with a seperate ticket).
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metrics.json 7bbf7be
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/widgets.json a64a2c8
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metrics.json 6fc808e
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json PRE-CREATION
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/widgets.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32957/diff/
>
>
> Testing
> -------
>
> Manually Teseted the patch on cluster
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 32957: Update widgets.json for HBase and add for
HDFS and YARN
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32957/#review79318
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/widgets.json
<https://reviews.apache.org/r/32957/#comment128575>
Extra space at the end.
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json
<https://reviews.apache.org/r/32957/#comment128573>
Typo. "Garnage" should be "Garbage"
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json
<https://reviews.apache.org/r/32957/#comment128574>
Why is this repeated?
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json
<https://reviews.apache.org/r/32957/#comment128576>
This should be "DataNode Garbage Collection Time"?
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json
<https://reviews.apache.org/r/32957/#comment128577>
This should be "DataNode Garbage Collection Time"?
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json
<https://reviews.apache.org/r/32957/#comment128578>
This should be "DataNode JVM Heap Memory Used"?
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json
<https://reviews.apache.org/r/32957/#comment128579>
This should be "DataNode JVM Heap Memory Used"?
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/widgets.json
<https://reviews.apache.org/r/32957/#comment128580>
For this and other NodeManager metrics, shouldn't we just say NodeManager rather than YARN?
For example, "NodeManager Garbage Collection Time" rather than "YARN Garbage Collection Time".
- Yusaku Sako
On April 8, 2015, 2:35 a.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32957/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 2:35 a.m.)
>
>
> Review request for Ambari, Sid Wagle and Yusaku Sako.
>
>
> Bugs: AMBARI-10393
> https://issues.apache.org/jira/browse/AMBARI-10393
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This includes updating HBase widgets.json and adding HDFS and YARN widgets.json files. These are default widget definitions which will be used to populate widget instances in ambari database on respective service resource creation (This will done with a seperate ticket).
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metrics.json 7bbf7be
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/widgets.json a64a2c8
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metrics.json 6fc808e
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json PRE-CREATION
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/widgets.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32957/diff/
>
>
> Testing
> -------
>
> Manually Teseted the patch on cluster
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 32957: Update widgets.json for HBase and add for
HDFS and YARN
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32957/#review80134
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On April 14, 2015, 6:28 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32957/
> -----------------------------------------------------------
>
> (Updated April 14, 2015, 6:28 p.m.)
>
>
> Review request for Ambari, Sid Wagle and Yusaku Sako.
>
>
> Bugs: AMBARI-10393
> https://issues.apache.org/jira/browse/AMBARI-10393
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This includes updating HBase widgets.json and adding HDFS and YARN widgets.json files. These are default widget definitions which will be used to populate widget instances in ambari database on respective service resource creation (This will done with a seperate ticket).
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metrics.json 7bbf7be
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/widgets.json a64a2c8
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metrics.json 6fc808e
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json PRE-CREATION
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metrics.json 327d10c
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/widgets.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/widgets.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32957/diff/
>
>
> Testing
> -------
>
> Manually Teseted the patch on cluster
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 32957: Update widgets.json for HBase and add for
HDFS and YARN
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32957/
-----------------------------------------------------------
(Updated April 14, 2015, 6:28 p.m.)
Review request for Ambari, Sid Wagle and Yusaku Sako.
Changes
-------
Patch changes UPDATED_BLOCKED_TIME to UPDATES_BLOCKED_TIME
Bugs: AMBARI-10393
https://issues.apache.org/jira/browse/AMBARI-10393
Repository: ambari
Description
-------
This includes updating HBase widgets.json and adding HDFS and YARN widgets.json files. These are default widget definitions which will be used to populate widget instances in ambari database on respective service resource creation (This will done with a seperate ticket).
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metrics.json 7bbf7be
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/widgets.json a64a2c8
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metrics.json 6fc808e
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json PRE-CREATION
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metrics.json 327d10c
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/widgets.json PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/widgets.json PRE-CREATION
Diff: https://reviews.apache.org/r/32957/diff/
Testing
-------
Manually Teseted the patch on cluster
Thanks,
Jaimin Jetly
Re: Review Request 32957: Update widgets.json for HBase and add for
HDFS and YARN
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32957/#review80040
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/widgets.json
<https://reviews.apache.org/r/32957/#comment129797>
Should be "Updates", not "Updated".
This metric is "Number of milliseconds updates have been blocked so the memstore can be flushed" per http://hbase.apache.org/book.html
- Yusaku Sako
On April 14, 2015, 6:24 a.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32957/
> -----------------------------------------------------------
>
> (Updated April 14, 2015, 6:24 a.m.)
>
>
> Review request for Ambari, Sid Wagle and Yusaku Sako.
>
>
> Bugs: AMBARI-10393
> https://issues.apache.org/jira/browse/AMBARI-10393
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This includes updating HBase widgets.json and adding HDFS and YARN widgets.json files. These are default widget definitions which will be used to populate widget instances in ambari database on respective service resource creation (This will done with a seperate ticket).
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metrics.json 7bbf7be
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/widgets.json a64a2c8
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metrics.json 6fc808e
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json PRE-CREATION
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metrics.json 327d10c
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/widgets.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/widgets.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32957/diff/
>
>
> Testing
> -------
>
> Manually Teseted the patch on cluster
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 32957: Update widgets.json for HBase and add for
HDFS and YARN
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32957/
-----------------------------------------------------------
(Updated April 14, 2015, 6:24 a.m.)
Review request for Ambari, Sid Wagle and Yusaku Sako.
Changes
-------
New patch addressess all the feedbacks and adds system metrics heatmaps, and creates default widget layout for heatmaps
Bugs: AMBARI-10393
https://issues.apache.org/jira/browse/AMBARI-10393
Repository: ambari
Description
-------
This includes updating HBase widgets.json and adding HDFS and YARN widgets.json files. These are default widget definitions which will be used to populate widget instances in ambari database on respective service resource creation (This will done with a seperate ticket).
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metrics.json 7bbf7be
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/widgets.json a64a2c8
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metrics.json 6fc808e
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json PRE-CREATION
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metrics.json 327d10c
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/widgets.json PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/widgets.json PRE-CREATION
Diff: https://reviews.apache.org/r/32957/diff/
Testing
-------
Manually Teseted the patch on cluster
Thanks,
Jaimin Jetly