Workflow executor issue... or bad use

[Christophe Chiarelli <ch...@radical-airlines.com>]

Hi,

While looking at last Hop v0.99 build, I'm in front of a strange issue.
I don't know if it's a problem or a wrong setup I did.

I created a pipeline with a component to get a file list in a folder.
Linked to it a workflow Executor step that should execute another workflow
for each file found in the source folder.
[image: image.png]


In the Workflow Executor step a parameter/variable defined "FILENAME"
mapped to the filename attribute coming from the Get Filename step.
[image: image.png]


The called workflow is quite simple too : I want to write the parameter
${FILENAME} in the logs and display an alert box
[image: image.png]

Hereunder the result at execution time :
[image: image.png]
The FILENAME parameter was not set correctly.


I also tried to use the sample transform delivered with the package without
success.
Just added a write to log to trap the value of PARAM and I have the same
problem :

[image: image.png]
For sure here i was expecting "one" / "two" / "three".
Did the same test with build v0.70 with no success either.

Doing the same thing with an old Kettle version and a Job Executor step, it
worked flawlessly.

While looking at the doc I think some paragraphs are deprecated : on
workflow page documentation talk about "args / arguments" and list some
checkbox and tabs - for sure in Kettle they exist - however I was not able
to find the Argument tab in the Hop workflow component. So I think it's no
more existing.

Regards,
Chris

Re: Workflow executor issue... or bad use

[Bart Maertens <ba...@know.bi>]

Hi Christophe,

Good to hear this fixed it for you.
Your feedback on the docs would be very valuable to us, it really helps us
to keep improving them.

Regards,
Bart

On Fri, Sep 17, 2021 at 5:33 PM Christophe Chiarelli <
chris@radical-airlines.com> wrote:

> Hi,
>
> Thanks for the clue indeed it works just fine by now
>
> [image: image.png]
> Will highlight some strange things for me in the online doc
>
> Best regards,
> Christophe
>
>
>
>> Le jeu. 16 sept. 2021 à 16:20, Hans Van Akelyen <
>> hans.van.akelyen@gmail.com> a écrit :
>>
>>> Hi Chris,
>>>
>>> Did a quick test and it should work, it might be you have forgotten is
>>> to add the variable to the workflow itself.
>>> When not adding the parameter in the workflow properties I get the same
>>> result.
>>>
>>> Can you check if you added the parameter under the workflow properties?
>>> [image: Screenshot 2021-09-16 at 16.08.18.png]
>>> [image: image.png]
>>> I tested on both our latest codebase and version 0.99.
>>>
>>> About the docs, could you point to the pages not matching the UI? We are
>>> always optimising our docs,
>>> when checking the workflow executor docs they seem to match the current
>>> transform [1].
>>>
>>> All feedback to improve is much appreciated.
>>>
>>> Hans
>>>
>>>
>>> [1]
>>> https://hop.apache.org/manual/latest/pipeline/transforms/workflowexecutor.html
>>>
>>>
>>> On Thu, 16 Sept 2021 at 15:54, Christophe Chiarelli <
>>> chris@radical-airlines.com> wrote:
>>>
>>>> Hi,
>>>>
>>>> While looking at last Hop v0.99 build, I'm in front of a strange issue.
>>>> I don't know if it's a problem or a wrong setup I did.
>>>>
>>>> I created a pipeline with a component to get a file list in a folder.
>>>> Linked to it a workflow Executor step that should execute another
>>>> workflow for each file found in the source folder.
>>>> [image: image.png]
>>>>
>>>>
>>>> In the Workflow Executor step a parameter/variable defined "FILENAME"
>>>> mapped to the filename attribute coming from the Get Filename step.
>>>> [image: image.png]
>>>>
>>>>
>>>> The called workflow is quite simple too : I want to write the parameter
>>>> ${FILENAME} in the logs and display an alert box
>>>> [image: image.png]
>>>>
>>>> Hereunder the result at execution time :
>>>> [image: image.png]
>>>> The FILENAME parameter was not set correctly.
>>>>
>>>>
>>>> I also tried to use the sample transform delivered with the package
>>>> without success.
>>>> Just added a write to log to trap the value of PARAM and I have the
>>>> same problem :
>>>>
>>>> [image: image.png]
>>>> For sure here i was expecting "one" / "two" / "three".
>>>> Did the same test with build v0.70 with no success either.
>>>>
>>>> Doing the same thing with an old Kettle version and a Job Executor
>>>> step, it worked flawlessly.
>>>>
>>>> While looking at the doc I think some paragraphs are deprecated : on
>>>> workflow page documentation talk about "args / arguments" and list some
>>>> checkbox and tabs - for sure in Kettle they exist - however I was not able
>>>> to find the Argument tab in the Hop workflow component. So I think it's no
>>>> more existing.
>>>>
>>>> Regards,
>>>> Chris
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>

Re: Workflow executor issue... or bad use

[Christophe Chiarelli <ch...@radical-airlines.com>]

 Hi,

Thanks for the clue indeed it works just fine by now

[image: image.png]
Will highlight some strange things for me in the online doc

Best regards,
Christophe



> Le jeu. 16 sept. 2021 à 16:20, Hans Van Akelyen <
> hans.van.akelyen@gmail.com> a écrit :
>
>> Hi Chris,
>>
>> Did a quick test and it should work, it might be you have forgotten is to
>> add the variable to the workflow itself.
>> When not adding the parameter in the workflow properties I get the same
>> result.
>>
>> Can you check if you added the parameter under the workflow properties?
>> [image: Screenshot 2021-09-16 at 16.08.18.png]
>> [image: image.png]
>> I tested on both our latest codebase and version 0.99.
>>
>> About the docs, could you point to the pages not matching the UI? We are
>> always optimising our docs,
>> when checking the workflow executor docs they seem to match the current
>> transform [1].
>>
>> All feedback to improve is much appreciated.
>>
>> Hans
>>
>>
>> [1]
>> https://hop.apache.org/manual/latest/pipeline/transforms/workflowexecutor.html
>>
>>
>> On Thu, 16 Sept 2021 at 15:54, Christophe Chiarelli <
>> chris@radical-airlines.com> wrote:
>>
>>> Hi,
>>>
>>> While looking at last Hop v0.99 build, I'm in front of a strange issue.
>>> I don't know if it's a problem or a wrong setup I did.
>>>
>>> I created a pipeline with a component to get a file list in a folder.
>>> Linked to it a workflow Executor step that should execute another
>>> workflow for each file found in the source folder.
>>> [image: image.png]
>>>
>>>
>>> In the Workflow Executor step a parameter/variable defined "FILENAME"
>>> mapped to the filename attribute coming from the Get Filename step.
>>> [image: image.png]
>>>
>>>
>>> The called workflow is quite simple too : I want to write the parameter
>>> ${FILENAME} in the logs and display an alert box
>>> [image: image.png]
>>>
>>> Hereunder the result at execution time :
>>> [image: image.png]
>>> The FILENAME parameter was not set correctly.
>>>
>>>
>>> I also tried to use the sample transform delivered with the package
>>> without success.
>>> Just added a write to log to trap the value of PARAM and I have the same
>>> problem :
>>>
>>> [image: image.png]
>>> For sure here i was expecting "one" / "two" / "three".
>>> Did the same test with build v0.70 with no success either.
>>>
>>> Doing the same thing with an old Kettle version and a Job Executor step,
>>> it worked flawlessly.
>>>
>>> While looking at the doc I think some paragraphs are deprecated : on
>>> workflow page documentation talk about "args / arguments" and list some
>>> checkbox and tabs - for sure in Kettle they exist - however I was not able
>>> to find the Argument tab in the Hop workflow component. So I think it's no
>>> more existing.
>>>
>>> Regards,
>>> Chris
>>>
>>>
>>>
>>>
>>>
>>>

Re: Workflow executor issue... or bad use

[Hans Van Akelyen <ha...@gmail.com>]

Hi Chris,

Did a quick test and it should work, it might be you have forgotten is to
add the variable to the workflow itself.
When not adding the parameter in the workflow properties I get the same
result.

Can you check if you added the parameter under the workflow properties?
[image: Screenshot 2021-09-16 at 16.08.18.png]
[image: image.png]
I tested on both our latest codebase and version 0.99.

About the docs, could you point to the pages not matching the UI? We are
always optimising our docs,
when checking the workflow executor docs they seem to match the current
transform [1].

All feedback to improve is much appreciated.

Hans


[1]
https://hop.apache.org/manual/latest/pipeline/transforms/workflowexecutor.html


On Thu, 16 Sept 2021 at 15:54, Christophe Chiarelli <
chris@radical-airlines.com> wrote:

> Hi,
>
> While looking at last Hop v0.99 build, I'm in front of a strange issue.
> I don't know if it's a problem or a wrong setup I did.
>
> I created a pipeline with a component to get a file list in a folder.
> Linked to it a workflow Executor step that should execute another workflow
> for each file found in the source folder.
> [image: image.png]
>
>
> In the Workflow Executor step a parameter/variable defined "FILENAME"
> mapped to the filename attribute coming from the Get Filename step.
> [image: image.png]
>
>
> The called workflow is quite simple too : I want to write the parameter
> ${FILENAME} in the logs and display an alert box
> [image: image.png]
>
> Hereunder the result at execution time :
> [image: image.png]
> The FILENAME parameter was not set correctly.
>
>
> I also tried to use the sample transform delivered with the package
> without success.
> Just added a write to log to trap the value of PARAM and I have the same
> problem :
>
> [image: image.png]
> For sure here i was expecting "one" / "two" / "three".
> Did the same test with build v0.70 with no success either.
>
> Doing the same thing with an old Kettle version and a Job Executor step,
> it worked flawlessly.
>
> While looking at the doc I think some paragraphs are deprecated : on
> workflow page documentation talk about "args / arguments" and list some
> checkbox and tabs - for sure in Kettle they exist - however I was not able
> to find the Argument tab in the Hop workflow component. So I think it's no
> more existing.
>
> Regards,
> Chris
>
>
>
>
>
>