You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nitin Galave <ni...@gmail.com> on 2021/06/03 12:46:18 UTC

Re: Review Request 73397: RANGER-3301: [UI] in admin audit log tebles not formated correctly for lone string value for resources.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73397/
-----------------------------------------------------------

(Updated June 3, 2021, 12:46 p.m.)


Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, Jayendra Parab, Kishor Gollapalliwar, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.


Summary (updated)
-----------------

RANGER-3301: [UI] in admin audit log  tebles not formated correctly for lone string value for resources.


Bugs: RANGER-3301
    https://issues.apache.org/jira/browse/RANGER-3301


Repository: ranger


Description (updated)
-------

Step to reproduce
1) Create hdfs service policy with resource path value to long string.
2)Check policy created log on Audit => Admin tab
3)In policy details popup table not formatted correctly.


Diffs (updated)
-----

  security-admin/src/main/webapp/styles/xa.css 9762a3b75 
  security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDeleteDiff_tmpl.html 31664023c 
  security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDiff_tmpl.html 5a54d628b 


Diff: https://reviews.apache.org/r/73397/diff/2/

Changes: https://reviews.apache.org/r/73397/diff/1-2/


Testing
-------

Tested that admin audit policy detail table, fields are correctly formatted for long string value for any fields value.


Thanks,

Nitin Galave


Re: Review Request 73397: RANGER-3301: [UI] in admin audit log tables not formated correctly for lone string value for resources.

Posted by Mehul Parikh <xs...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73397/#review223115
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On June 7, 2021, 1:40 p.m., Nitin Galave wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73397/
> -----------------------------------------------------------
> 
> (Updated June 7, 2021, 1:40 p.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, Jayendra Parab, Kishor Gollapalliwar, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3301
>     https://issues.apache.org/jira/browse/RANGER-3301
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Step to reproduce
> 1) Create hdfs service policy with resource path value to long string.
> 2)Check policy created log on Audit => Admin tab
> 3)In policy details popup table not formatted correctly.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/styles/xa.css 9762a3b75 
>   security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDeleteDiff_tmpl.html 31664023c 
>   security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDiff_tmpl.html 5a54d628b 
> 
> 
> Diff: https://reviews.apache.org/r/73397/diff/2/
> 
> 
> Testing
> -------
> 
> Tested that admin audit policy detail table, fields are correctly formatted for long string value for any fields value.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>


Re: Review Request 73397: RANGER-3301: [UI] in admin audit log tables not formated correctly for lone string value for resources.

Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73397/#review223118
-----------------------------------------------------------


Ship it!




Ship It!

- Pradeep Agrawal


On June 7, 2021, 1:40 p.m., Nitin Galave wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73397/
> -----------------------------------------------------------
> 
> (Updated June 7, 2021, 1:40 p.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, Jayendra Parab, Kishor Gollapalliwar, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3301
>     https://issues.apache.org/jira/browse/RANGER-3301
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Step to reproduce
> 1) Create hdfs service policy with resource path value to long string.
> 2)Check policy created log on Audit => Admin tab
> 3)In policy details popup table not formatted correctly.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/styles/xa.css 9762a3b75 
>   security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDeleteDiff_tmpl.html 31664023c 
>   security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDiff_tmpl.html 5a54d628b 
> 
> 
> Diff: https://reviews.apache.org/r/73397/diff/2/
> 
> 
> Testing
> -------
> 
> Tested that admin audit policy detail table, fields are correctly formatted for long string value for any fields value.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>


Re: Review Request 73397: RANGER-3301: [UI] in admin audit log tables not formated correctly for lone string value for resources.

Posted by Nitin Galave <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73397/
-----------------------------------------------------------

(Updated June 7, 2021, 1:40 p.m.)


Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, Jayendra Parab, Kishor Gollapalliwar, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.


Summary (updated)
-----------------

RANGER-3301: [UI] in admin audit log tables not formated correctly for lone string value for resources.


Bugs: RANGER-3301
    https://issues.apache.org/jira/browse/RANGER-3301


Repository: ranger


Description
-------

Step to reproduce
1) Create hdfs service policy with resource path value to long string.
2)Check policy created log on Audit => Admin tab
3)In policy details popup table not formatted correctly.


Diffs
-----

  security-admin/src/main/webapp/styles/xa.css 9762a3b75 
  security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDeleteDiff_tmpl.html 31664023c 
  security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDiff_tmpl.html 5a54d628b 


Diff: https://reviews.apache.org/r/73397/diff/2/


Testing
-------

Tested that admin audit policy detail table, fields are correctly formatted for long string value for any fields value.


Thanks,

Nitin Galave