[jira] [Commented] (BROOKLYN-64) Persist + rebind feeds

["Aled Sage (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BROOKLYN-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280109#comment-14280109 ] 

Aled Sage commented on BROOKLYN-64:
-----------------------------------

Persistence of feeds is now supported. For a feed to be persisted, the entity must be written to call `addFeed(feed)`, which registers this feed so that it will be recreated.

There are two reasons for this: first that it is consistent with having `addPolicy()` and `addEnricher()` etc; second that it means authors of existing entities have to explicitly review their code before their feeds will be persisted. The feed must be written to not have an anonymous inner class, which is a criteria that quite a few entities fail - so turning on persistence of feeds automatically would cause lots of warnings in the log.

The next stage of this work is to go through our entity implementations, to ensure they are creating and using feeds in such a way that they can be and are persisted.

> Persist + rebind feeds
> ----------------------
>
>                 Key: BROOKLYN-64
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-64
>             Project: Brooklyn
>          Issue Type: Improvement
>            Reporter: Aled Sage
>
> The state of "feeds" attached to entities (e.g. JmxFeed that polls over JMX to populate sensors) should be persisted, allowing rebind on Brooklyn restart or on brooklyn failover.
> Aled and Alex suggest that feeds should also be changed to extend EntityAdjunct.
> See https://github.com/apache/incubator-brooklyn/pull/108 for ongoing work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)