[jira] [Commented] (IGNITE-13136) Calcite integration. Improve join predicate testing.

["Aleksey Plekhanov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-13136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383363#comment-17383363 ] 

Aleksey Plekhanov commented on IGNITE-13136:
--------------------------------------------

[~zstan], please see my comments on GitHub.

> Calcite integration. Improve join predicate testing.
> ----------------------------------------------------
>
>                 Key: IGNITE-13136
>                 URL: https://issues.apache.org/jira/browse/IGNITE-13136
>             Project: Ignite
>          Issue Type: Improvement
>          Components: sql
>            Reporter: Roman Kondakov
>            Assignee: Stanilovsky Evgeny
>            Priority: Minor
>              Labels: calcite, calcite2-required, calcite3-required
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently we have to merge joining rows in order to test a join predicate:
> {code:java}
>     Row row = handler.concat(left, rightMaterialized.get(rightIdx++));
>     if (!cond.test(row))
>         continue;
> {code}
> it results in unconditional building a joined row even if it will not be emitted to downstream further. To avoid extra GC pressure we need to test the join predicate before joining rows:
> {code:java}
>     if (!cond.test(left, right))
>         continue;
>     Row row = handler.concat(left, right);
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)