You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "LinuxSuRen (via GitHub)" <gi...@apache.org> on 2023/11/03 08:15:36 UTC
[PR] fix: some links are broken in the doc [skywalking-banyandb]
LinuxSuRen opened a new pull request, #350:
URL: https://github.com/apache/skywalking-banyandb/pull/350
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: some links are broken in the doc [skywalking-banyandb]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #350:
URL: https://github.com/apache/skywalking-banyandb/pull/350#issuecomment-1792047583
Could you refer main repo to add dead link check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: some links are broken in the doc [skywalking-banyandb]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily commented on PR #350:
URL: https://github.com/apache/skywalking-banyandb/pull/350#issuecomment-1792527045
It's nice to see the dead link checker work as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: some links are broken in the doc [skywalking-banyandb]
Posted by "LinuxSuRen (via GitHub)" <gi...@apache.org>.
LinuxSuRen commented on PR #350:
URL: https://github.com/apache/skywalking-banyandb/pull/350#issuecomment-1792051978
> Could you refer main repo to add dead link check?
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: some links are broken in the doc [skywalking-banyandb]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #350:
URL: https://github.com/apache/skywalking-banyandb/pull/350#issuecomment-1792387081
> There is an image URL is broken. Is there anyone know it?
>
> FILE: ./docs/concept/persistence-storage.md [✖] https://skywalking.apache.org/doc-graph/banyandb/v0.5.0/io_uring.png
It is a jpg. Ref URL, https://skywalking.apache.org/doc-graph/banyandb/v0.5.0/io_uring.jpg
The original file is hosted here, https://github.com/apache/skywalking-website/blob/master/static/doc-graph/banyandb/v0.5.0/io_uring.jpg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: some links are broken in the doc [skywalking-banyandb]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #350:
URL: https://github.com/apache/skywalking-banyandb/pull/350#issuecomment-1792054279
## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/350?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#350](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/350?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b397c77) into [main](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/222ca556c2a1aa974145ad6f2fefcf612bd68174?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (222ca55) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #350 +/- ##
==========================================
- Coverage 38.25% 38.23% -0.02%
==========================================
Files 117 117
Lines 12831 12831
==========================================
- Hits 4908 4906 -2
- Misses 7442 7444 +2
Partials 481 481
```
[see 1 file with indirect coverage changes](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in [Chrome](https://chrome.google.com/webstore/detail/codecov/gedikamndpbemklijjkncpnolildpbgo) or [Firefox](https://addons.mozilla.org/en-US/firefox/addon/codecov/) today!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: some links are broken in the doc [skywalking-banyandb]
Posted by "LinuxSuRen (via GitHub)" <gi...@apache.org>.
LinuxSuRen commented on PR #350:
URL: https://github.com/apache/skywalking-banyandb/pull/350#issuecomment-1792124964
There is an image URL is broken. Is there anyone know it?
FILE: ./docs/concept/persistence-storage.md
[✖] https://skywalking.apache.org/doc-graph/banyandb/v0.5.0/io_uring.png
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: some links are broken in the doc [skywalking-banyandb]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #350:
URL: https://github.com/apache/skywalking-banyandb/pull/350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org