You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by st...@hyperreal.org on 2000/01/19 02:33:19 UTC
cvs commit: apache-2.0/src/modules/standard mod_userdir.c
stoddard 00/01/18 17:33:17
Modified: src/modules/standard mod_userdir.c
Log:
Fix Windows compile break. Gotta find a better way to fix this.
Revision Changes Path
1.6 +2 -0 apache-2.0/src/modules/standard/mod_userdir.c
Index: mod_userdir.c
===================================================================
RCS file: /home/cvs/apache-2.0/src/modules/standard/mod_userdir.c,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- mod_userdir.c 2000/01/18 23:41:56 1.5
+++ mod_userdir.c 2000/01/19 01:33:16 1.6
@@ -93,7 +93,9 @@
#include "httpd.h"
#include "http_config.h"
#include "http_request.h"
+#ifndef WIN32
#include <pwd.h>
+#endif
/* The default directory in user's home dir */
#ifndef DEFAULT_USER_DIR
Re: cvs commit: apache-2.0/src/modules/standard mod_userdir.c
Posted by Dean Gaudet <dg...@arctic.org>.
On Tue, 18 Jan 2000, Manoj Kasichainula wrote:
> Seriously, we should all (including me) be doing more of what David is
> doing and writing up docs that would be useful to newbie coders.
docs are cool... but what you just wrote could easily be plopped into the
src/docs directory and committed, and it serves as a stop-gap until
someone does write docs...
Dean
Re: cvs commit: apache-2.0/src/modules/standard mod_userdir.c
Posted by Manoj Kasichainula <ma...@io.com>.
On Tue, Jan 18, 2000 at 09:38:45PM -0500, Bill Stoddard wrote:
> Can you document this somewhere too? This bit of info will be lost in the
> noise otherwise.
Dude, you have commit access to the repository too. :)
Seriously, we should all (including me) be doing more of what David is
doing and writing up docs that would be useful to newbie coders.
But, it would be far, far easier (and IMO more useful) if we had a
kickass mailing-list search engine.
Re: cvs commit: apache-2.0/src/modules/standard mod_userdir.c
Posted by rb...@apache.org.
On Tue, 18 Jan 2000, Bill Stoddard wrote:
> Can you document this somewhere too? This bit of info will be lost in the
> noise otherwise.
This has been documented in the CVS commit. I'll document it more in the
file about upgrading modules probably later this week, and when we
actually spend time writing the docs for 2.0, it will get documented there
too.
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@ntrnet.net
6209 H Shanda Dr.
Raleigh, NC 27609 Ryan Bloom -- thinker, adventurer, artist,
writer, but mostly, friend.
-------------------------------------------------------------------------------
Re: cvs commit: apache-2.0/src/modules/standard mod_userdir.c
Posted by Bill Stoddard <st...@raleigh.ibm.com>.
Can you document this somewhere too? This bit of info will be lost in the
noise otherwise.
______________________________________________
Bill Stoddard
Come to the first official Apache Software Foundation
Conference! <http://ApacheCon.Com/>
----- Original Message -----
From: <rb...@apache.org>
To: <ne...@apache.org>
Sent: Tuesday, January 18, 2000 9:37 PM
Subject: Re: cvs commit: apache-2.0/src/modules/standard mod_userdir.c
>
>
> This finally dawned on me after I posted the note. How long have you been
> trying to explain this to me??? Sorry I've been a bit dense the last
> week. I'm committing this change now.
>
> Ryan
>
> On Tue, 18 Jan 2000, Manoj Kasichainula wrote:
>
> > On Wed, Jan 19, 2000 at 01:43:24AM -0500, Ryan Bloom wrote:
> > >
> > > The better way to fix it is for Apache to provide an AP_HAVE_PWD_H
macro
> > > depending on what autoconf finds. This is all part of the autoconf
not
> > > protecting their own macros problem. This will be fixed in time, but
how
> > > to do it is a real problem. I am seriously considering doing what we
did
> > > for APR, which is to create another header file for public namespace
> > > protected macros.
> >
> > I don't think so.
> >
> > Apache and its bundled modules all share a single configuration and
> > all use the same Apache autoconf include files. The only reason for
> > this is convenience.
> >
> > Because Apache's bundled modules are developed along with Apache (so
> > we don't have to worry about namespace collisions), and because they
> > share the same configuration data, they should include ap_config.h
> >
> > Modules that do their own configuration (such as PHP) don't need any
> > help from Apache, so they shouldn't include ap_config.h.
> >
> > So to summarize: the easiest way to fix mod_userdir, or any other
> > module with similar problems, is to just include ap_config.h.
> >
> >
>
>
____________________________________________________________________________
___
> Ryan Bloom rbb@ntrnet.net
> 6209 H Shanda Dr.
> Raleigh, NC 27609 Ryan Bloom -- thinker, adventurer, artist,
> writer, but mostly, friend.
> --------------------------------------------------------------------------
-----
>
Re: cvs commit: apache-2.0/src/modules/standard mod_userdir.c
Posted by rb...@apache.org.
This finally dawned on me after I posted the note. How long have you been
trying to explain this to me??? Sorry I've been a bit dense the last
week. I'm committing this change now.
Ryan
On Tue, 18 Jan 2000, Manoj Kasichainula wrote:
> On Wed, Jan 19, 2000 at 01:43:24AM -0500, Ryan Bloom wrote:
> >
> > The better way to fix it is for Apache to provide an AP_HAVE_PWD_H macro
> > depending on what autoconf finds. This is all part of the autoconf not
> > protecting their own macros problem. This will be fixed in time, but how
> > to do it is a real problem. I am seriously considering doing what we did
> > for APR, which is to create another header file for public namespace
> > protected macros.
>
> I don't think so.
>
> Apache and its bundled modules all share a single configuration and
> all use the same Apache autoconf include files. The only reason for
> this is convenience.
>
> Because Apache's bundled modules are developed along with Apache (so
> we don't have to worry about namespace collisions), and because they
> share the same configuration data, they should include ap_config.h
>
> Modules that do their own configuration (such as PHP) don't need any
> help from Apache, so they shouldn't include ap_config.h.
>
> So to summarize: the easiest way to fix mod_userdir, or any other
> module with similar problems, is to just include ap_config.h.
>
>
_______________________________________________________________________________
Ryan Bloom rbb@ntrnet.net
6209 H Shanda Dr.
Raleigh, NC 27609 Ryan Bloom -- thinker, adventurer, artist,
writer, but mostly, friend.
-------------------------------------------------------------------------------
Re: cvs commit: apache-2.0/src/modules/standard mod_userdir.c
Posted by Manoj Kasichainula <ma...@io.com>.
On Wed, Jan 19, 2000 at 01:43:24AM -0500, Ryan Bloom wrote:
>
> The better way to fix it is for Apache to provide an AP_HAVE_PWD_H macro
> depending on what autoconf finds. This is all part of the autoconf not
> protecting their own macros problem. This will be fixed in time, but how
> to do it is a real problem. I am seriously considering doing what we did
> for APR, which is to create another header file for public namespace
> protected macros.
I don't think so.
Apache and its bundled modules all share a single configuration and
all use the same Apache autoconf include files. The only reason for
this is convenience.
Because Apache's bundled modules are developed along with Apache (so
we don't have to worry about namespace collisions), and because they
share the same configuration data, they should include ap_config.h
Modules that do their own configuration (such as PHP) don't need any
help from Apache, so they shouldn't include ap_config.h.
So to summarize: the easiest way to fix mod_userdir, or any other
module with similar problems, is to just include ap_config.h.
Re: cvs commit: apache-2.0/src/modules/standard mod_userdir.c
Posted by Bill Stoddard <st...@raleigh.ibm.com>.
Humm, I've never tried it, but it is included in the build. If it doesn't
work, I'll take it out of the build.
______________________________________________
Bill Stoddard
Come to the first official Apache Software Foundation
Conference! <http://ApacheCon.Com/>
----- Original Message -----
From: "Ryan Bloom" <rb...@raleigh.ibm.com>
To: <ne...@apache.org>
Cc: <ap...@apache.org>
Sent: Wednesday, January 19, 2000 1:43 AM
Subject: Re: cvs commit: apache-2.0/src/modules/standard mod_userdir.c
>
> The better way to fix it is for Apache to provide an AP_HAVE_PWD_H macro
> depending on what autoconf finds. This is all part of the autoconf not
> protecting their own macros problem. This will be fixed in time, but how
> to do it is a real problem. I am seriously considering doing what we did
> for APR, which is to create another header file for public namespace
> protected macros. BTW, why are you bothering with userdir? I didn't
> think it worked on Windows.
>
> Ryan
>
>
> On 19 Jan 2000 stoddard@hyperreal.org wrote:
>
> > stoddard 00/01/18 17:33:17
> >
> > Modified: src/modules/standard mod_userdir.c
> > Log:
> > Fix Windows compile break. Gotta find a better way to fix this.
> >
> > Revision Changes Path
> > 1.6 +2 -0 apache-2.0/src/modules/standard/mod_userdir.c
> >
> > Index: mod_userdir.c
> > ===================================================================
> > RCS file: /home/cvs/apache-2.0/src/modules/standard/mod_userdir.c,v
> > retrieving revision 1.5
> > retrieving revision 1.6
> > diff -u -r1.5 -r1.6
> > --- mod_userdir.c 2000/01/18 23:41:56 1.5
> > +++ mod_userdir.c 2000/01/19 01:33:16 1.6
> > @@ -93,7 +93,9 @@
> > #include "httpd.h"
> > #include "http_config.h"
> > #include "http_request.h"
> > +#ifndef WIN32
> > #include <pwd.h>
> > +#endif
> >
> > /* The default directory in user's home dir */
> > #ifndef DEFAULT_USER_DIR
> >
> >
> >
> >
>
> _______________________________________________________________________
> Ryan Bloom rbb@raleigh.ibm.com
> 4205 S Miami Blvd
> RTP, NC 27709
>
> Come to the first official Apache Software Foundation
> Conference! <http://ApacheCon.Com/>
>
>
Re: cvs commit: apache-2.0/src/modules/standard mod_userdir.c
Posted by David Reid <ab...@dial.pipex.com>.
makes sense and keeps the modules simpler and potentially more flexible.
----- Original Message -----
From: "Dean Gaudet" <dg...@arctic.org>
To: <ne...@apache.org>
Sent: Wednesday, January 19, 2000 10:08 PM
Subject: Re: cvs commit: apache-2.0/src/modules/standard mod_userdir.c
>
>
> On Tue, 18 Jan 2000, Bill Stoddard wrote:
>
> > > an even better way is to admit that mod_userdir is a unix-specific
thing
> > > and not even try to compile it elsewhere...
> > >
> > Yep.
>
> maybe modules/unix/mod_userdir.c ?
>
> Dean
>
Re: cvs commit: apache-2.0/src/modules/standard mod_userdir.c
Posted by Dean Gaudet <dg...@arctic.org>.
On Tue, 18 Jan 2000, Bill Stoddard wrote:
> > an even better way is to admit that mod_userdir is a unix-specific thing
> > and not even try to compile it elsewhere...
> >
> Yep.
maybe modules/unix/mod_userdir.c ?
Dean
Re: cvs commit: apache-2.0/src/modules/standard mod_userdir.c
Posted by Bill Stoddard <st...@raleigh.ibm.com>.
> an even better way is to admit that mod_userdir is a unix-specific thing
> and not even try to compile it elsewhere...
>
Yep.
Re: cvs commit: apache-2.0/src/modules/standard mod_userdir.c
Posted by Dean Gaudet <dg...@arctic.org>.
an even better way is to admit that mod_userdir is a unix-specific thing
and not even try to compile it elsewhere...
Dean
On Wed, 19 Jan 2000, Ryan Bloom wrote:
>
> The better way to fix it is for Apache to provide an AP_HAVE_PWD_H macro
> depending on what autoconf finds. This is all part of the autoconf not
> protecting their own macros problem. This will be fixed in time, but how
> to do it is a real problem. I am seriously considering doing what we did
> for APR, which is to create another header file for public namespace
> protected macros. BTW, why are you bothering with userdir? I didn't
> think it worked on Windows.
>
> Ryan
>
>
> On 19 Jan 2000 stoddard@hyperreal.org wrote:
>
> > stoddard 00/01/18 17:33:17
> >
> > Modified: src/modules/standard mod_userdir.c
> > Log:
> > Fix Windows compile break. Gotta find a better way to fix this.
> >
> > Revision Changes Path
> > 1.6 +2 -0 apache-2.0/src/modules/standard/mod_userdir.c
> >
> > Index: mod_userdir.c
> > ===================================================================
> > RCS file: /home/cvs/apache-2.0/src/modules/standard/mod_userdir.c,v
> > retrieving revision 1.5
> > retrieving revision 1.6
> > diff -u -r1.5 -r1.6
> > --- mod_userdir.c 2000/01/18 23:41:56 1.5
> > +++ mod_userdir.c 2000/01/19 01:33:16 1.6
> > @@ -93,7 +93,9 @@
> > #include "httpd.h"
> > #include "http_config.h"
> > #include "http_request.h"
> > +#ifndef WIN32
> > #include <pwd.h>
> > +#endif
> >
> > /* The default directory in user's home dir */
> > #ifndef DEFAULT_USER_DIR
> >
> >
> >
> >
>
> _______________________________________________________________________
> Ryan Bloom rbb@raleigh.ibm.com
> 4205 S Miami Blvd
> RTP, NC 27709
>
> Come to the first official Apache Software Foundation
> Conference! <http://ApacheCon.Com/>
>
>
>
Re: cvs commit: apache-2.0/src/modules/standard mod_userdir.c
Posted by Ryan Bloom <rb...@raleigh.ibm.com>.
The better way to fix it is for Apache to provide an AP_HAVE_PWD_H macro
depending on what autoconf finds. This is all part of the autoconf not
protecting their own macros problem. This will be fixed in time, but how
to do it is a real problem. I am seriously considering doing what we did
for APR, which is to create another header file for public namespace
protected macros. BTW, why are you bothering with userdir? I didn't
think it worked on Windows.
Ryan
On 19 Jan 2000 stoddard@hyperreal.org wrote:
> stoddard 00/01/18 17:33:17
>
> Modified: src/modules/standard mod_userdir.c
> Log:
> Fix Windows compile break. Gotta find a better way to fix this.
>
> Revision Changes Path
> 1.6 +2 -0 apache-2.0/src/modules/standard/mod_userdir.c
>
> Index: mod_userdir.c
> ===================================================================
> RCS file: /home/cvs/apache-2.0/src/modules/standard/mod_userdir.c,v
> retrieving revision 1.5
> retrieving revision 1.6
> diff -u -r1.5 -r1.6
> --- mod_userdir.c 2000/01/18 23:41:56 1.5
> +++ mod_userdir.c 2000/01/19 01:33:16 1.6
> @@ -93,7 +93,9 @@
> #include "httpd.h"
> #include "http_config.h"
> #include "http_request.h"
> +#ifndef WIN32
> #include <pwd.h>
> +#endif
>
> /* The default directory in user's home dir */
> #ifndef DEFAULT_USER_DIR
>
>
>
>
_______________________________________________________________________
Ryan Bloom rbb@raleigh.ibm.com
4205 S Miami Blvd
RTP, NC 27709
Come to the first official Apache Software Foundation
Conference! <http://ApacheCon.Com/>
Re: cvs commit: apache-2.0/src/modules/standard mod_userdir.c
Posted by Ryan Bloom <rb...@raleigh.ibm.com>.
The better way to fix it is for Apache to provide an AP_HAVE_PWD_H macro
depending on what autoconf finds. This is all part of the autoconf not
protecting their own macros problem. This will be fixed in time, but how
to do it is a real problem. I am seriously considering doing what we did
for APR, which is to create another header file for public namespace
protected macros. BTW, why are you bothering with userdir? I didn't
think it worked on Windows.
Ryan
On 19 Jan 2000 stoddard@hyperreal.org wrote:
> stoddard 00/01/18 17:33:17
>
> Modified: src/modules/standard mod_userdir.c
> Log:
> Fix Windows compile break. Gotta find a better way to fix this.
>
> Revision Changes Path
> 1.6 +2 -0 apache-2.0/src/modules/standard/mod_userdir.c
>
> Index: mod_userdir.c
> ===================================================================
> RCS file: /home/cvs/apache-2.0/src/modules/standard/mod_userdir.c,v
> retrieving revision 1.5
> retrieving revision 1.6
> diff -u -r1.5 -r1.6
> --- mod_userdir.c 2000/01/18 23:41:56 1.5
> +++ mod_userdir.c 2000/01/19 01:33:16 1.6
> @@ -93,7 +93,9 @@
> #include "httpd.h"
> #include "http_config.h"
> #include "http_request.h"
> +#ifndef WIN32
> #include <pwd.h>
> +#endif
>
> /* The default directory in user's home dir */
> #ifndef DEFAULT_USER_DIR
>
>
>
>
_______________________________________________________________________
Ryan Bloom rbb@raleigh.ibm.com
4205 S Miami Blvd
RTP, NC 27709
Come to the first official Apache Software Foundation
Conference! <http://ApacheCon.Com/>