[GitHub] Ethanlm commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology

[GitBox <gi...@apache.org>]

Ethanlm commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology
URL: https://github.com/apache/storm/pull/2957#discussion_r258516472
 
 

 ##########
 File path: storm-server/src/test/java/org/apache/storm/scheduler/resource/TestResourceAwareScheduler.java
 ##########
 @@ -252,6 +270,7 @@ public void testTopologySetCpuAndMemLoad() {
         TopologyDetails topology1 = new TopologyDetails("topology1", config, stormTopology1, 0, executorMap1, 0, "user");
 
         ResourceAwareScheduler rs = new ResourceAwareScheduler();
+        scheduler = rs;
 
 Review comment:
   Same as above. Could we use `scheduler = new ResourceAwareScheduler();` directly?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services