You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by hl...@apache.org on 2004/03/09 17:11:55 UTC
cvs commit: jakarta-tapestry/framework/src/org/apache/tapestry/engine AbstractEngine.java
hlship 2004/03/09 08:11:55
Modified: . status.xml .cvsignore
framework/src/org/apache/tapestry/engine AbstractEngine.java
Log:
23544: Avoid calling request.getRemoteHost()
Revision Changes Path
1.21 +6 -1 jakarta-tapestry/status.xml
Index: status.xml
===================================================================
RCS file: /home/cvs/jakarta-tapestry/status.xml,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -r1.20 -r1.21
--- status.xml 3 Mar 2004 00:42:51 -0000 1.20
+++ status.xml 9 Mar 2004 16:11:55 -0000 1.21
@@ -484,6 +484,11 @@
Fixed one more place where the encoding needs to be set
</action>
+<action type="fix" dev="HLS" fixes-bug="23544">
+Don't use <code>request.getRemoteHost()</code> since that requires
+an expensive reverse DNS lookup.
+</action>
+
</release>
</changes>
</status>
1.10 +1 -0 jakarta-tapestry/.cvsignore
Index: .cvsignore
===================================================================
RCS file: /home/cvs/jakarta-tapestry/.cvsignore,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- .cvsignore 9 Jan 2004 02:20:06 -0000 1.9
+++ .cvsignore 9 Mar 2004 16:11:55 -0000 1.10
@@ -7,3 +7,4 @@
velocity.log
*.out
build
+${destdir}
1.29 +6 -2 jakarta-tapestry/framework/src/org/apache/tapestry/engine/AbstractEngine.java
Index: AbstractEngine.java
===================================================================
RCS file: /home/cvs/jakarta-tapestry/framework/src/org/apache/tapestry/engine/AbstractEngine.java,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -r1.28 -r1.29
--- AbstractEngine.java 19 Feb 2004 17:38:00 -0000 1.28
+++ AbstractEngine.java 9 Mar 2004 16:11:55 -0000 1.29
@@ -1199,7 +1199,11 @@
else
_sessionId = null;
- _clientAddress = request.getRemoteHost();
+ // Previously, this used getRemoteHost(), but that requires an
+ // expensive reverse DNS lookup. Possibly, the host name lookup
+ // should occur ... but only if there's an actual error message
+ // to display.
+
if (_clientAddress == null)
_clientAddress = request.getRemoteAddr();
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org