You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/11 11:36:47 UTC
[GitHub] [airflow] turbaszek opened a new pull request #8813: Refactor BigQuery check operators
turbaszek opened a new pull request #8813:
URL: https://github.com/apache/airflow/pull/8813
This commit applies some code formatting to existing BigQuery check operators. It also adds location parameter to `BigQueryIntervalCheckOperator` and `BigQueryValueCheckOperator`.
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #8813: Refactor BigQuery check operators
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #8813:
URL: https://github.com/apache/airflow/pull/8813#discussion_r422978054
##########
File path: airflow/providers/google/cloud/operators/bigquery.py
##########
@@ -120,8 +123,7 @@ class BigQueryCheckOperator(CheckOperator):
:param use_legacy_sql: Whether to use legacy SQL (true)
or standard SQL (false).
:type use_legacy_sql: bool
- :param location: The geographic location of the job. Required except for
- US and EU. See details at
+ :param location: The geographic location of the job.
Review comment:
```suggestion
:param location: The geographic location of the job. See details at:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #8813: Refactor BigQuery check operators
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #8813:
URL: https://github.com/apache/airflow/pull/8813#discussion_r422978054
##########
File path: airflow/providers/google/cloud/operators/bigquery.py
##########
@@ -120,8 +123,7 @@ class BigQueryCheckOperator(CheckOperator):
:param use_legacy_sql: Whether to use legacy SQL (true)
or standard SQL (false).
:type use_legacy_sql: bool
- :param location: The geographic location of the job. Required except for
- US and EU. See details at
+ :param location: The geographic location of the job.
Review comment:
```suggestion
:param location: The geographic location of the job. See details at:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org