[GitHub] [airflow] uranusjr commented on a diff in pull request #31663: Logging from all containers in KubernetesOperatorPod

["uranusjr (via GitHub)" <gi...@apache.org>]

uranusjr commented on code in PR #31663:
URL: https://github.com/apache/airflow/pull/31663#discussion_r1251524796


##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -342,6 +348,9 @@ def __init__(
         self.cluster_context = cluster_context
         self.reattach_on_restart = reattach_on_restart
         self.get_logs = get_logs
+        self.container_logs = container_logs
+        if base_container_name and self.container_logs == KubernetesPodOperator.BASE_CONTAINER_NAME:

Review Comment:
   But in that case `self.container_logs` would be set to `KubernetesPodOperator.BASE_CONTAINER_NAME`. Would that work? If not, I would prefer this combination to raise a ValueError instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org