You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "jsedding (via GitHub)" <gi...@apache.org> on 2025/08/14 14:31:34 UTC
[PR] OAK-11860 - oak-segment-azure should perform I/O in parallel [jackrabbit-oak]
jsedding opened a new pull request, #2453:
URL: https://github.com/apache/jackrabbit-oak/pull/2453
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11860 - oak-segment-azure should perform I/O in parallel [jackrabbit-oak]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2453:
URL: https://github.com/apache/jackrabbit-oak/pull/2453#issuecomment-3189060000
## [](https://sonarcloud.io/dashboard?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2453) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2453&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2453&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2453&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [93.5% Coverage on New Code](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2453&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2453&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2453)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11860 - oak-segment-azure should perform I/O in parallel [jackrabbit-oak]
Posted by "jelmini (via GitHub)" <gi...@apache.org>.
jelmini commented on PR #2453:
URL: https://github.com/apache/jackrabbit-oak/pull/2453#issuecomment-3196687634
I wonder if parallelizing `AzureArchiveManager#delete` is safe, in case Oak crashes while deleting the archive. Currently `AzureArchiveManager#listArchives` considers an archive to be deleted if no blob starting with `0000.` is present. By parallelizing, the segment starting with `0000.` may be deleted after other blobs (other segments or the `closed` blob). In case of crash, the `0000.` may still be there: `TarReader`will then attempt to open the archive and fail, preventing the repository to initialize.
However, I'm not even sure the current sequential code is safe either, as the order of the blobs returned by `AzureUtilities#getBlobs` is not specified.
In any case, I suggest to validate the behavior in case of crash before introducing this change in `AzureArchiveManager#delete`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11860 - oak-segment-azure should perform I/O in parallel [jackrabbit-oak]
Posted by "jsedding (via GitHub)" <gi...@apache.org>.
jsedding closed pull request #2453: OAK-11860 - oak-segment-azure should perform I/O in parallel
URL: https://github.com/apache/jackrabbit-oak/pull/2453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11860 - oak-segment-azure should perform I/O in parallel [jackrabbit-oak]
Posted by "jsedding (via GitHub)" <gi...@apache.org>.
jsedding commented on PR #2453:
URL: https://github.com/apache/jackrabbit-oak/pull/2453#issuecomment-3197059159
Interesting consideration, @jelmini ! Even though not related to my change, as you acknowledge.
How about we write a marker file `deleted` into the archive? And then we kick off a daemon thread to perform the actual delete. If we check for this file at startup, we could also start a daemon thread for the deletion(s). That way deletions would be somewhat atomic. WDYT? But that warrants its own ticket IMHO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11860 - oak-segment-azure should perform I/O in parallel [jackrabbit-oak]
Posted by "jsedding (via GitHub)" <gi...@apache.org>.
jsedding commented on PR #2453:
URL: https://github.com/apache/jackrabbit-oak/pull/2453#issuecomment-3206513494
I'll close this PR for now. This is becoming very complex, possibly for little gain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11860 - oak-segment-azure should perform I/O in parallel [jackrabbit-oak]
Posted by "jsedding (via GitHub)" <gi...@apache.org>.
jsedding commented on PR #2453:
URL: https://github.com/apache/jackrabbit-oak/pull/2453#issuecomment-3197136906
I have created OAK-11867 to track atomic deletes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11860 - oak-segment-azure should perform I/O in parallel [jackrabbit-oak]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2453:
URL: https://github.com/apache/jackrabbit-oak/pull/2453#issuecomment-3188673709
# Commit-Check ✔️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org