You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by "Daniel Keir Haywood (Jira)" <ji...@apache.org> on 2021/04/05 10:17:00 UTC
[jira] [Updated] (ISIS-2596) Use Identifier#getTranslationContext()
consistently
[ https://issues.apache.org/jira/browse/ISIS-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Keir Haywood updated ISIS-2596:
--------------------------------------
Summary: Use Identifier#getTranslationContext() consistently (was: Provide more context to TranslationService for collections.)
> Use Identifier#getTranslationContext() consistently
> ---------------------------------------------------
>
> Key: ISIS-2596
> URL: https://issues.apache.org/jira/browse/ISIS-2596
> Project: Isis
> Issue Type: Improvement
> Components: Isis Core
> Affects Versions: 2.0.0-M5
> Reporter: Daniel Keir Haywood
> Priority: Minor
> Fix For: 2.0.0-M6
>
>
> from [https://the-asf.slack.com/archives/CFC42LWBV/p1617614428185000?thread_ts=1617614189.183900&cid=CFC42LWBV]
>
> The VisitorAdapter that handles the translations does not implement visit for FieldSets, rather the translations for FieldSets are picked up during the traversing of properties, but then all the context goes missing for some reason
>
> it would be nice to have more than the class name as context I guess
>
> maybe the {{MemberOrderFacetXml}} facet that does the ordering of the members shouldn't also handle translations? There seems to be quite a few cases where it makes more sense to use the ID for ordering, but then the ID is not the text that should be translated I guess
--
This message was sent by Atlassian Jira
(v8.3.4#803005)