You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/09/02 21:38:30 UTC
[GitHub] [incubator-mxnet] r3stl355 opened a new pull request #19078: [BUGFIX] Assure NDArray.reshape does not change the array size
r3stl355 opened a new pull request #19078:
URL: https://github.com/apache/incubator-mxnet/pull/19078
## Description ##
Solves [#18886](https://github.com/apache/incubator-mxnet/issues/18886)
## Checklist ##
### Essentials ###
- [X] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [X] Changes are complete (i.e. I finished coding on this PR)
- [X] All changes have test coverage
- [X] Code is well-documented
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] r3stl355 commented on pull request #19078: [BUGFIX] Assure NDArray.reshape does not change the array size
Posted by GitBox <gi...@apache.org>.
r3stl355 commented on pull request #19078:
URL: https://github.com/apache/incubator-mxnet/pull/19078#issuecomment-687656145
Can anyone review this please so I can implement the same against 1.x branches? It looks like it now has some conflicts, should I resolve those locally and re-submit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] r3stl355 commented on pull request #19078: [BUGFIX] Assure NDArray.reshape does not change the array size
Posted by GitBox <gi...@apache.org>.
r3stl355 commented on pull request #19078:
URL: https://github.com/apache/incubator-mxnet/pull/19078#issuecomment-686559558
@mxnet-bot run ci [unix-cpu,unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19078: [BUGFIX] Assure NDArray.reshape does not change the array size
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19078:
URL: https://github.com/apache/incubator-mxnet/pull/19078#issuecomment-686634304
Jenkins CI successfully triggered : [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu merged pull request #19078: [BUGFIX] Assure NDArray.reshape does not change the array size
Posted by GitBox <gi...@apache.org>.
marcoabreu merged pull request #19078:
URL: https://github.com/apache/incubator-mxnet/pull/19078
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] r3stl355 commented on pull request #19078: [BUGFIX] Assure NDArray.reshape does not change the array size
Posted by GitBox <gi...@apache.org>.
r3stl355 commented on pull request #19078:
URL: https://github.com/apache/incubator-mxnet/pull/19078#issuecomment-687659682
Sure, will do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] r3stl355 commented on pull request #19078: [BUGFIX] Assure NDArray.reshape does not change the array size
Posted by GitBox <gi...@apache.org>.
r3stl355 commented on pull request #19078:
URL: https://github.com/apache/incubator-mxnet/pull/19078#issuecomment-686634256
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19078: [BUGFIX] Assure NDArray.reshape does not change the array size
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19078:
URL: https://github.com/apache/incubator-mxnet/pull/19078#issuecomment-686559614
Jenkins CI successfully triggered : [unix-gpu, unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19078: [BUGFIX] Assure NDArray.reshape does not change the array size
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19078:
URL: https://github.com/apache/incubator-mxnet/pull/19078#issuecomment-687740362
Jenkins CI successfully triggered : [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19078: [BUGFIX] Assure NDArray.reshape does not change the array size
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19078:
URL: https://github.com/apache/incubator-mxnet/pull/19078#issuecomment-686043183
Hey @r3stl355 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-gpu, unix-cpu, miscellaneous, windows-cpu, unix-gpu, sanity, website, centos-gpu, centos-cpu, edge, clang]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] r3stl355 commented on pull request #19078: [BUGFIX] Assure NDArray.reshape does not change the array size
Posted by GitBox <gi...@apache.org>.
r3stl355 commented on pull request #19078:
URL: https://github.com/apache/incubator-mxnet/pull/19078#issuecomment-687740346
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #19078: [BUGFIX] Assure NDArray.reshape does not change the array size
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #19078:
URL: https://github.com/apache/incubator-mxnet/pull/19078#issuecomment-687659210
@r3stl355 we deprecated contrib text in master. could you rebase?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org