You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/14 18:27:41 UTC

[GitHub] [beam] pabloem commented on a change in pull request #11710: [BEAM-9964] Setting --workerCacheMB for Streaming Pipeline

pabloem commented on a change in pull request #11710:
URL: https://github.com/apache/beam/pull/11710#discussion_r425345741



##########
File path: runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/WindmillStateCacheTest.java
##########
@@ -130,7 +133,8 @@ private static StateNamespace triggerNamespace(long start, int triggerIdx) {
 
   @Before
   public void setUp() {
-    cache = new WindmillStateCache();
+    options = PipelineOptionsFactory.as(DataflowWorkerHarnessOptions.class);
+    cache = new WindmillStateCache(options.getWorkerCacheMb());
     assertEquals(0, cache.getWeight());

Review comment:
       Can you add a check to this test to make sure that the `maximumWeight` of the cache is the 100 MB? (perhaps use a number different than 100 to be sure).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org