You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/15 20:35:37 UTC
[GitHub] [airflow] ryanahamilton opened a new pull request #11564: Webpack CSS Minification
ryanahamilton opened a new pull request #11564:
URL: https://github.com/apache/airflow/pull/11564
Adds/implements the [OptimizeCSSAssetsPlugin](https://github.com/NMFR/optimize-css-assets-webpack-plugin) Webpack plugin to minify CSS files on-compile as is best practice for Production applications.
- Updated the license comments in all of the CSS/JS/PUML files so that they begin with `/*!` instead of `/**`. This ensures that these comments are preserved during minification (all other comments are stripped out).
- Updated the pre-commit insert-license action to use the `/*!` syntax for all CSS/JS/PUML files going forward.
**Reduction in file sizes:**
| Asset | Size Before | Size After | Diff |
|---|---|---|---|
| airflowDefaultTheme.css | 124 KiB | 102 KiB | -17.74% |
| bootstrap-datetimepicker.min.css | 7.6 KiB | 7.46 KiB | -1.84% |
| dataTables.bootstrap.min.css | 4.25 KiB | 4.11 KiB | -3.29% |
| flash.css | 1.36 KiB | 1.05 KiB | -22.79% |
| gantt.css | 1.29 KiB | 1.1 KiB | -14.73% |
| graph.css | 2.08 KiB | 1.78 KiB | -14.42% |
| loadingDots.css | 1.35 KiB | 1.21 KiB | -10.37% |
| main.css | 9.03 KiB | 5.95 KiB | -34.11% |
| materialIcons.css | 109 KiB | 109 KiB | 0 |
| nv.d3.min.css | 8.22 KiB | 8.13 KiB | -1.09% |
| switch.css | 2.06 KiB | 1.79 KiB | -13.11% |
| tree.css | 1.85 KiB | 1.58 KiB | -14.59% |
**Example of new output:**
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #11564: Webpack CSS Minification
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #11564:
URL: https://github.com/apache/airflow/pull/11564
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org