You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Ben Collins-Sussman <su...@collab.net> on 2004/07/07 17:17:40 UTC
Re: [Issue 1770] current status (was: Re: herding 1.1 issues into
the corral)
On Wed, 2004-07-07 at 09:58, Peter N. Lundblad wrote:
> On Tue, 6 Jul 2004, Ben Collins-Sussman wrote:
>
> > ### 1770: non-ascii path truncated by 'svn blame'. Peter L, how close
> > are you to fixing this?
> >
> This is fixed but not for all RA implementations. But the fix isn't
> enough, I think. The problem is that just URI-encoding the path returned
> from the svn_repos_find_root_path call (and appenging that to what
> preceded the path in the URL) might not give the same string as the
> original path part. One way to fix this, I beleive would be to count the
> number of segments in the root path and remove the rest from the incoming
> URL. The client relies on the lengths being the same length as the URL
> used to open the RA session. Another approach would be to canonicalize the
> URI with regards to the URI-encoding, but this is a bigger change and also
> an API change since it makes stricter requirenments on a parameter.
>
> I'll try this, but I'm not sure I will hit the time frame of 1.1. If
> anyone else is intrerested, just tell me.
Urg, this seems pretty complicated. And it's not a critical issue. I'd
rather you focus your efforts on finishing #1715 ASAP. I can just push
this issue into 1.2.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [Issue 1770] current status (was: Re: herding 1.1 issues into
the corral)
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Wed, 7 Jul 2004, Ben Collins-Sussman wrote:
> On Wed, 2004-07-07 at 09:58, Peter N. Lundblad wrote:
> > On Tue, 6 Jul 2004, Ben Collins-Sussman wrote:
> >
> > > ### 1770: non-ascii path truncated by 'svn blame'. Peter L, how close
> > > are you to fixing this?
> > >
> > This is fixed but not for all RA implementations. But the fix isn't
> > enough, I think. The problem is that just URI-encoding the path returned
> > from the svn_repos_find_root_path call (and appenging that to what
> > preceded the path in the URL) might not give the same string as the
> > original path part. One way to fix this, I beleive would be to count the
> > number of segments in the root path and remove the rest from the incoming
> > URL. The client relies on the lengths being the same length as the URL
> > used to open the RA session. Another approach would be to canonicalize the
> > URI with regards to the URI-encoding, but this is a bigger change and also
> > an API change since it makes stricter requirenments on a parameter.
> >
> > I'll try this, but I'm not sure I will hit the time frame of 1.1. If
> > anyone else is intrerested, just tell me.
>
> Urg, this seems pretty complicated. And it's not a critical issue. I'd
> rather you focus your efforts on finishing #1715 ASAP. I can just push
> this issue into 1.2.
>
Yes, I will hopefully finish 1715 tonight.
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org