You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/22 04:59:30 UTC
[GitHub] [arrow-rs] HaoYang670 opened a new issue #1350: Refactor `RecordBatch::validate_new_batch`
HaoYang670 opened a new issue #1350:
URL: https://github.com/apache/arrow-rs/issues/1350
**Describe the bug**
The function `validate_new_batch` constains some repetitive code. We could find a way to refactor it.
https://github.com/apache/arrow-rs/blob/master/arrow/src/record_batch.rs#L133-L166
**To Reproduce**
**Expected behavior**
Clean and readable code
**Additional context**
Add any other context about the problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] HaoYang670 commented on issue #1350: Refactor `RecordBatch::validate_new_batch`
Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on issue #1350:
URL: https://github.com/apache/arrow-rs/issues/1350#issuecomment-1048602550
@alamb Is this refactoring worth doing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] HaoYang670 edited a comment on issue #1350: Refactor `RecordBatch::validate_new_batch`
Posted by GitBox <gi...@apache.org>.
HaoYang670 edited a comment on issue #1350:
URL: https://github.com/apache/arrow-rs/issues/1350#issuecomment-1048602550
@alamb Is this refactoring worth to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on issue #1350: Refactor `RecordBatch::validate_new_batch`
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #1350:
URL: https://github.com/apache/arrow-rs/issues/1350#issuecomment-1053697244
Hi @HaoYang670 -- sorry i am just getting back from a week away. I will check this (and the linked PR out) over the next day or two
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] HaoYang670 commented on issue #1350: Refactor `RecordBatch::validate_new_batch`
Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on issue #1350:
URL: https://github.com/apache/arrow-rs/issues/1350#issuecomment-1047429549
Using `Iterator.find` or `Iterator.any` may be a good choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb closed issue #1350: Refactor `RecordBatch::validate_new_batch`
Posted by GitBox <gi...@apache.org>.
alamb closed issue #1350:
URL: https://github.com/apache/arrow-rs/issues/1350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org