You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by yiming187 <gi...@git.apache.org> on 2017/02/08 08:21:17 UTC

[GitHub] zeppelin pull request #1988: [ZEPPELIN-2080] Fix null column parse issue in ...

GitHub user yiming187 opened a pull request:

    https://github.com/apache/zeppelin/pull/1988

    [ZEPPELIN-2080] Fix null column parse issue in KylinInterpreter

    ### What is this PR for?
    KylinInterpreter use regex pattern "\"results\":\\[\\[\"(.*?)\"]]" to extract the result, but if the last column is null, then no quotes in that field. The regex pattern will fail to match.
    The KylinInterpreter should consider to support the null field case.
    
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2080
    
    ### How should this be tested?
    Has prepared the testcase in UnitTest
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update?No
    * Is there breaking changes for older versions?No
    * Does this needs documentation?No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yiming187/zeppelin ZEPPELIN-2080

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1988.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1988
    
----
commit 741977dd0c462bc7bffac8a742e7f6cbaaf5c18d
Author: Billy Liu <bi...@apache.org>
Date:   2017-02-08T08:18:46Z

    [ZEPPELIN-2080] Fix null column parse issue in KylinInterpreter

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1988: [ZEPPELIN-2080] Fix null column parse issue in ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1988


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1988: [ZEPPELIN-2080] Fix null column parse issue in KylinIn...

Posted by jongyoul <gi...@git.apache.org>.

Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/1988
  
    Thanks. LGTM. If CI finished and become green, will merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1988: [ZEPPELIN-2080] Fix null column parse issue in KylinIn...

Posted by felixcheung <gi...@git.apache.org>.

Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/1988
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---