You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Mark Hanson (Jira)" <ji...@apache.org> on 2022/05/12 18:17:00 UTC

[jira] [Created] (GEODE-10306) CacheServerImpl should stop the acceptor immediately after stop is called

Mark Hanson created GEODE-10306:
-----------------------------------

             Summary: CacheServerImpl should stop the acceptor immediately after stop is called
                 Key: GEODE-10306
                 URL: https://issues.apache.org/jira/browse/GEODE-10306
             Project: Geode
          Issue Type: Bug
            Reporter: Mark Hanson


Currently, after cache server stop is called, it takes a while for the acceptor to stop taking new data, which can be a problem because the bigger the window of time, the greater the risk of data loss. 

 
{noformat}
public synchronized void stop() {
  if (!isRunning()) {
    return;
  }

  RuntimeException firstException = null;

  try {
    if (loadMonitor != null) {
      loadMonitor.stop();
    }
  } catch (RuntimeException e) {
    logger.warn("CacheServer - Error closing load monitor", e);
    firstException = e;
  }

  try {
    if (advisor != null) {
      advisor.close();
    }
  } catch (RuntimeException e) {
    logger.warn("CacheServer - Error closing advisor", e);
    firstException = e;
  }

PROBLEM ->  try {
    if (acceptor != null) {
      acceptor.close();
    }
  } catch (RuntimeException e) {
    logger.warn("CacheServer - Error closing acceptor monitor", e);
    if (firstException != null) {
      firstException = e;
    }
  } {noformat}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)