[GitHub] [dubbo-go-samples] beiwei30 commented on a change in pull request #59: add: direct README

[GitBox <gi...@apache.org>]

beiwei30 commented on a change in pull request #59:
URL: https://github.com/apache/dubbo-go-samples/pull/59#discussion_r588383832



##########
File path: direct/go-client/conf/client.yml
##########
@@ -37,25 +28,25 @@ references:
         retries: 3
 
 # protocol config
-protocol_conf:
-  dubbo:
-    reconnect_interval: 0
-    connection_number: 1
-    heartbeat_period: "5s"
-    session_timeout: "180s"
-    pool_size: 64
-    pool_ttl: 600
-    getty_session_param:
-      compress_encoding: false
-      tcp_no_delay: true
-      tcp_keep_alive: true
-      keep_alive_period: "120s"
-      tcp_r_buf_size: 262144
-      tcp_w_buf_size: 65536
-      pkg_rq_size: 1024
-      pkg_wq_size: 512
-      tcp_read_timeout: "1s"
-      tcp_write_timeout: "5s"
-      wait_timeout: "1s"
-      max_msg_len: 1024000
-      session_name: "client"
\ No newline at end of file
+#protocol_conf:

Review comment:
       don't comment out, if it's unnessary, simply remove it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org