You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by KyungJae Lee <ko...@gmail.com> on 2014/05/08 04:58:13 UTC
Review Request 21192: Project Invitation & System Alert Message Email Send
SMTP Auth & Port Fix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21192/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
I worked for sending e-mail change my Project Invitation & System Alert Message.
I have divided the authentication of the User SSL and useAuth settings smtp.
So, I added alert.smtp.ssl, the project.smtp.ssl items in Global Configuration.
In addition, it has been sending the Port that is Fix when specifying the SMTP Port in Global Configuration existing.
I have modified to receive and process the value of the option.
Diffs
-----
server/src/com/cloud/alert/AlertManagerImpl.java 3786443
server/src/com/cloud/configuration/Config.java 6ebb7e6
server/src/com/cloud/projects/ProjectManagerImpl.java 22e2020
server/src/com/cloud/smtp/XtrmSMTPTransport.java PRE-CREATION
usage/src/com/cloud/usage/UsageAlertManagerImpl.java 01e6bec
Diff: https://reviews.apache.org/r/21192/diff/
Testing
-------
Thanks,
KyungJae Lee
Re: Review Request 21192: Project Invitation & System Alert Message
Email Send SMTP Auth & Port Fix
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21192/#review78998
-----------------------------------------------------------
Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.
We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).
Please consider submitting a pull request.
Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md
Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.
- Sebastien Goasguen
On May 8, 2014, 2:58 a.m., KyungJae Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21192/
> -----------------------------------------------------------
>
> (Updated May 8, 2014, 2:58 a.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> I worked for sending e-mail change my Project Invitation & System Alert Message.
> I have divided the authentication of the User SSL and useAuth settings smtp.
> So, I added alert.smtp.ssl, the project.smtp.ssl items in Global Configuration.
> In addition, it has been sending the Port that is Fix when specifying the SMTP Port in Global Configuration existing.
> I have modified to receive and process the value of the option.
>
>
> Diffs
> -----
>
> server/src/com/cloud/alert/AlertManagerImpl.java 3786443
> server/src/com/cloud/configuration/Config.java 6ebb7e6
> server/src/com/cloud/projects/ProjectManagerImpl.java 22e2020
> server/src/com/cloud/smtp/XtrmSMTPTransport.java PRE-CREATION
> usage/src/com/cloud/usage/UsageAlertManagerImpl.java 01e6bec
>
> Diff: https://reviews.apache.org/r/21192/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> KyungJae Lee
>
>
Re: Review Request 21192: Project Invitation & System Alert Message
Email Send SMTP Auth & Port Fix
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21192/#review64030
-----------------------------------------------------------
Interesting feature, can you send a new patch that applies cleanly on master. Thanks.
- Rohit Yadav
On May 8, 2014, 2:58 a.m., KyungJae Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21192/
> -----------------------------------------------------------
>
> (Updated May 8, 2014, 2:58 a.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> I worked for sending e-mail change my Project Invitation & System Alert Message.
> I have divided the authentication of the User SSL and useAuth settings smtp.
> So, I added alert.smtp.ssl, the project.smtp.ssl items in Global Configuration.
> In addition, it has been sending the Port that is Fix when specifying the SMTP Port in Global Configuration existing.
> I have modified to receive and process the value of the option.
>
>
> Diffs
> -----
>
> server/src/com/cloud/alert/AlertManagerImpl.java 3786443
> server/src/com/cloud/configuration/Config.java 6ebb7e6
> server/src/com/cloud/projects/ProjectManagerImpl.java 22e2020
> server/src/com/cloud/smtp/XtrmSMTPTransport.java PRE-CREATION
> usage/src/com/cloud/usage/UsageAlertManagerImpl.java 01e6bec
>
> Diff: https://reviews.apache.org/r/21192/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> KyungJae Lee
>
>