You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/23 04:31:51 UTC
[GitHub] [arrow] westonpace opened a new pull request #10787: ARROW-13440: [C++] UBSAN error "applying non-zero offset to null pointer"
westonpace opened a new pull request #10787:
URL: https://github.com/apache/arrow/pull/10787
I'm not sure disabling the warning is the way to go. However, it appears we are explicitly testing this scenario so I'm not sure if that means we think it is a valid scenario or if the test was just to double check we don't break things in the event of an error.
The tests in question are `TestSetBitRunReader, Empty` and `TestBitmapUInt64Reader, Empty`. In both cases a bitmap reader is explicitly created with a nullptr and various offsets. Ideally we could apply the suppression at the test method level but I couldn't figure out a way to make the suppression work on a parent method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10787: ARROW-13440: [C++] UBSAN error "applying non-zero offset to null pointer"
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10787:
URL: https://github.com/apache/arrow/pull/10787#issuecomment-885392262
https://issues.apache.org/jira/browse/ARROW-13440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace closed pull request #10787: ARROW-13440: [C++] UBSAN error "applying non-zero offset to null pointer"
Posted by GitBox <gi...@apache.org>.
westonpace closed pull request #10787:
URL: https://github.com/apache/arrow/pull/10787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #10787: ARROW-13440: [C++] UBSAN error "applying non-zero offset to null pointer"
Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #10787:
URL: https://github.com/apache/arrow/pull/10787#issuecomment-887769891
Closing this as it is addressed in #10814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on a change in pull request #10787: ARROW-13440: [C++] UBSAN error "applying non-zero offset to null pointer"
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on a change in pull request #10787:
URL: https://github.com/apache/arrow/pull/10787#discussion_r675309542
##########
File path: cpp/src/arrow/util/bit_run_reader.h
##########
@@ -202,6 +202,9 @@ class BaseSetBitRunReader {
remaining_(length_),
current_word_(0),
current_num_bits_(0) {
+ if (bitmap_ == NULLPTR) {
+ return;
+ }
Review comment:
assert `length` must also be 0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org