You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/01 00:13:27 UTC
[GitHub] [incubator-nuttx] yamt opened a new issue #4005: TCP_STOPPED is unused
yamt opened a new issue #4005:
URL: https://github.com/apache/incubator-nuttx/issues/4005
we have no code to set TCP_STOPPED.
it seems like a leftover of the original uIP api, namely uip_stop/uip_stopped, which have been removed in 2014.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on issue #4005: TCP_STOPPED is unused
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #4005:
URL: https://github.com/apache/incubator-nuttx/issues/4005#issuecomment-871868633
i don't know what it was either.
it might be something similar to shutdown(SHUT_RD).
wrt implementing shutdown for us, my bet is that it's simpler to implement it from scratch than try to revive this uip_stop things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on issue #4005: TCP_STOPPED is unused
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #4005:
URL: https://github.com/apache/incubator-nuttx/issues/4005#issuecomment-871810934
the commit which removed the api:
```
commit 5d7915e5efd92c779fe546ae1985fd977f82d2bb
Author: Gregory Nutt <gn...@nuttx.org>
Date: Mon Jun 30 19:03:01 2014 -0600
NET: Remove uip_stopped and uip_stop
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on issue #4005: TCP_STOPPED is unused
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #4005:
URL: https://github.com/apache/incubator-nuttx/issues/4005#issuecomment-871810048
@patacongo have you kept this for reasons? otherwise i'd like to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on issue #4005: TCP_STOPPED is unused
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #4005:
URL: https://github.com/apache/incubator-nuttx/issues/4005#issuecomment-871885257
> my bet is that it's simpler to implement it from scratch than try to revive this uip_stop things.
I agree. I wasn't suggesting that. The uip_stop thing was TCP specific. shutdown() applies to all traffic https://pubs.opengroup.org/onlinepubs/009695399/functions/shutdown.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on issue #4005: TCP_STOPPED is unused
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #4005:
URL: https://github.com/apache/incubator-nuttx/issues/4005#issuecomment-871842144
> @patacongo have you kept this for reasons? otherwise i'd like to remove it.
No, no reason. Looks like it just wasn't completely removed. The remaining logic does nothing since it tests the flag but there is no logic to set it.
I am not even sure what it was. Perhaps it was the moral equivalent of shutdown()?
shutdown() is one of the important missing network APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on issue #4005: TCP_STOPPED is unused
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #4005:
URL: https://github.com/apache/incubator-nuttx/issues/4005#issuecomment-871888069
> > my bet is that it's simpler to implement it from scratch than try to revive this uip_stop things.
>
> I agree. I wasn't suggesting that. The uip_stop thing was TCP specific. shutdown() applies to all traffic https://pubs.opengroup.org/onlinepubs/009695399/functions/shutdown.html
well, i meant this TCP_STOPPED bit doesn't seem so useful for shutdown.
the uip_stop api is of course out of question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org