You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/22 16:17:26 UTC
[GitHub] [maven] michael-o commented on a diff in pull request #845: Fix versions comparison
michael-o commented on code in PR #845:
URL: https://github.com/apache/maven/pull/845#discussion_r1002518336
##########
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java:
##########
@@ -354,15 +354,15 @@ public String toString()
implements Item
{
private static final List<String> QUALIFIERS =
- Arrays.asList( "alpha", "beta", "milestone", "rc", "snapshot", "", "sp" );
+ Arrays.asList( "alpha", "beta", "milestone", "preview", "rc", "snapshot", "", "sp" );
private static final Properties ALIASES = new Properties();
static
{
- ALIASES.put( "ga", "" );
+ ALIASES.put( "cr", "rc" );
ALIASES.put( "final", "" );
+ ALIASES.put( "ga", "" );
ALIASES.put( "release", "" );
- ALIASES.put( "cr", "rc" );
}
Review Comment:
What is the benefit of this reorder? None, no?
##########
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java:
##########
@@ -354,15 +354,15 @@ public String toString()
implements Item
{
private static final List<String> QUALIFIERS =
- Arrays.asList( "alpha", "beta", "milestone", "rc", "snapshot", "", "sp" );
+ Arrays.asList( "alpha", "beta", "milestone", "preview", "rc", "snapshot", "", "sp" );
Review Comment:
What is the difference between preview and release candidate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org