You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Xi Wang <xw...@hortonworks.com> on 2017/03/28 18:46:05 UTC

Review Request 58000: Unable to scroll down collapsed navigation bar if it's higher that viewport

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58000/
-----------------------------------------------------------

Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, and Yusaku Sako.


Bugs: AMBARI-20610
    https://issues.apache.org/jira/browse/AMBARI-20610


Repository: ambari


Description
-------

If viewport height is not enough to display all items of navigation bar, user is able to scroll it down in expanded state, but it's not possible for "collapsed "sidebar.


Diffs
-----

  ambari-web/app/styles/theme/bootstrap-ambari.css b289517 
  ambari-web/vendor/scripts/theme/bootstrap-ambari.js 5cdbb55 


Diff: https://reviews.apache.org/r/58000/diff/1/


Testing
-------

20606 passing (24s)
128 pending


Thanks,

Xi Wang


Re: Review Request 58000: Unable to scroll down collapsed navigation bar if it's higher that viewport

Posted by Vivek Ratnavel Subramanian <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58000/#review170490
-----------------------------------------------------------


Ship it!




Ship It!

- Vivek Ratnavel Subramanian


On March 28, 2017, 6:46 p.m., Xi Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58000/
> -----------------------------------------------------------
> 
> (Updated March 28, 2017, 6:46 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20610
>     https://issues.apache.org/jira/browse/AMBARI-20610
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If viewport height is not enough to display all items of navigation bar, user is able to scroll it down in expanded state, but it's not possible for "collapsed "sidebar.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/styles/theme/bootstrap-ambari.css b289517 
>   ambari-web/vendor/scripts/theme/bootstrap-ambari.js 5cdbb55 
> 
> 
> Diff: https://reviews.apache.org/r/58000/diff/1/
> 
> 
> Testing
> -------
> 
> 20606 passing (24s)
> 128 pending
> 
> 
> Thanks,
> 
> Xi Wang
> 
>