You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/05/30 05:42:09 UTC
[GitHub] [incubator-druid] clintropolis commented on issue #7791: Fix
repeatedly expr parsing in ExpressionPostAggregation
clintropolis commented on issue #7791: Fix repeatedly expr parsing in ExpressionPostAggregation
URL: https://github.com/apache/incubator-druid/pull/7791#issuecomment-497210520
>BTW, I also found that the ExpressionVirtualColumn and ExpressionDimFilter don't have the repeatedly parsing pattern as only the parsed expressions are passed around, probably it's not necessary to make the Supplier change
It is indeed true that they are not as inefficient as the post agg, but I still think it's worth doing because there are still scenarios where un-necessary parsing is done when we are forced to parse just by deserializing the types, such as the router which doesn't actually need to parse or evaluate the expressions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org