You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/02/06 17:42:55 UTC
Re: Review Request 65496: Fixed a bug relating to lingering executors
[2/2].
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65496/
-----------------------------------------------------------
(Updated Feb. 6, 2018, 9:42 a.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Patch summary updated to reflect it is the second half of a fix.
Summary (updated)
-----------------
Fixed a bug relating to lingering executors [2/2].
Bugs: MESOS-8411
https://issues.apache.org/jira/browse/MESOS-8411
Repository: mesos
Description
-------
A task-less v1 executor could linger if the agent fails before
any of the executor's initial tasks got delivered.
This patch fixes this issue by checking if an executor is
task-less during the executor `subscribe()` and shutdown
the executor accordingly.
Diffs (updated)
-----
src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4
Diff: https://reviews.apache.org/r/65496/diff/2/
Changes: https://reviews.apache.org/r/65496/diff/1-2/
Testing
-------
make check.
Dedicated test #65497
Thanks,
Meng Zhu
Re: Review Request 65496: Fixed a bug relating to lingering executors
[2/2].
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65496/#review197067
-----------------------------------------------------------
Ship it!
This description doesn't seem to capture the cause of the issue here? Mentioning something about the everSentTask check occurs before we've removed the dropped tasks would be helpful for posterity.
- Benjamin Mahler
On Feb. 6, 2018, 5:42 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65496/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:42 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-8411
> https://issues.apache.org/jira/browse/MESOS-8411
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A task-less v1 executor could linger if the agent fails before
> any of the executor's initial tasks got delivered.
>
> This patch fixes this issue by checking if an executor is
> task-less during the executor `subscribe()` and shutdown
> the executor accordingly.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4
>
>
> Diff: https://reviews.apache.org/r/65496/diff/2/
>
>
> Testing
> -------
>
> make check.
> Dedicated test #65497
>
>
> Thanks,
>
> Meng Zhu
>
>