You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2017/03/09 15:37:40 UTC

[GitHub] nifi pull request #1582: NIFI-3575: Prevent unintended move events

GitHub user mcgilman opened a pull request:

    https://github.com/apache/nifi/pull/1582

    NIFI-3575: Prevent unintended move events

    - Verify that when moving a snippet, we do not attempt to move a process group into itself.
    - Update the UI to ensure a subsequent move event cannot be triggered while a previous move event is still in progress.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mcgilman/nifi NIFI-3575

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1582.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1582
    
----
commit 93921b63c774defc624e8a62c2769cd3b1fc1ee9
Author: Matt Gilman <ma...@gmail.com>
Date:   2017-03-09T15:34:55Z

    NIFI-3575:
    - Verify that when moving a snippet, we do not attempt to move a process group into itself.
    - Update the UI to ensure a subsequent move event cannot be triggered while a previous move event is still in progress.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1582: NIFI-3575: Prevent unintended move events

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/1582


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1582: NIFI-3575: Prevent unintended move events

Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/1582
  
    Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1582: NIFI-3575: Prevent unintended move events

Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/1582
  
    Ran contrib-check and tests and verified that the behavior was no longer possible. Merged. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1582: NIFI-3575: Prevent unintended move events

Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1582#discussion_r105520036
  
    --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java ---
    @@ -2261,6 +2262,23 @@ private void verifyContents(final Snippet snippet) throws NullPointerException,
         }
     
         /**
    +     * Verifies the a move request cannot attempt to move a process group into itself.
    --- End diff --
    
    Fixed this typo locally, will merge. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1582: NIFI-3575: Prevent unintended move events

Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:

    https://github.com/apache/nifi/pull/1582
  
    I left this guidance on the JIRA for anyone testing/reviewing... 
    
    > Feel free to apply the server side changes first. This should prevent NiFi from getting into this state. You should see an error indicating that you cannot move a Process Group into itself. Then applying the UI changes, it should make this sort of request impossible from the UI.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---