You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stu Hood (JIRA)" <ji...@apache.org> on 2009/12/10 04:19:18 UTC
[jira] Commented: (CASSANDRA-614) Fix Findbugs: Static initializers
[ https://issues.apache.org/jira/browse/CASSANDRA-614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788468#action_12788468 ]
Stu Hood commented on CASSANDRA-614:
------------------------------------
Looks good to me. +1
> Fix Findbugs: Static initializers
> ---------------------------------
>
> Key: CASSANDRA-614
> URL: https://issues.apache.org/jira/browse/CASSANDRA-614
> Project: Cassandra
> Issue Type: Bug
> Reporter: Stu Hood
> Assignee: Jonathan Ellis
> Attachments: 614.patch, lazy-init.txt
>
>
> We have a few singleton classes that are not doing their lazy initialization correctly (we really need a generic solution to this problem, sigh). In most cases, we are missing 'volatile' on the static field. See attached.
> In order to find unused method parameters for CASSANDRA-608, I ran FindBugs against Cassandra, and found a few interesting issues we ought to explore (but not the unused method params, oi.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.