You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/03/16 16:38:30 UTC
[GitHub] [hadoop-ozone] vivekratnavel opened a new pull request #689:
HDDS-3183. Deprecate old Recon HTTP Server Keytab config key.
vivekratnavel opened a new pull request #689: HDDS-3183. Deprecate old Recon HTTP Server Keytab config key.
URL: https://github.com/apache/hadoop-ozone/pull/689
## What changes were proposed in this pull request?
- Deprecate old config: `ozone.recon.keytab.file`
- Introduce new config: `ozone.recon.http.kerberos.keytab.file`
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3183
## How was this patch tested?
This patch was tested in a real cluster with both old config and new config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] avijayanhwx merged pull request #689: HDDS-3183.
Deprecate old Recon HTTP Server Keytab config key.
Posted by GitBox <gi...@apache.org>.
avijayanhwx merged pull request #689: HDDS-3183. Deprecate old Recon HTTP Server Keytab config key.
URL: https://github.com/apache/hadoop-ozone/pull/689
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] avijayanhwx commented on issue #689: HDDS-3183.
Deprecate old Recon HTTP Server Keytab config key.
Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on issue #689: HDDS-3183. Deprecate old Recon HTTP Server Keytab config key.
URL: https://github.com/apache/hadoop-ozone/pull/689#issuecomment-600932848
The unit test failure is unrelated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request
#689: HDDS-3183. Deprecate old Recon HTTP Server Keytab config key.
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on a change in pull request #689: HDDS-3183. Deprecate old Recon HTTP Server Keytab config key.
URL: https://github.com/apache/hadoop-ozone/pull/689#discussion_r394570555
##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ConfigurationProvider.java
##########
@@ -32,10 +33,17 @@
private static OzoneConfiguration configuration;
+ private static void addDeprecations() {
+ Configuration.addDeprecation(
+ ReconServerConfigKeys.OZONE_RECON_HTTP_KEYTAB_FILE_OLD,
+ ReconServerConfigKeys.OZONE_RECON_HTTP_KEYTAB_FILE);
+ }
+
@VisibleForTesting
public static void setConfiguration(OzoneConfiguration conf) {
if (configuration == null) {
ConfigurationProvider.configuration = conf;
+ ConfigurationProvider.addDeprecations();
Review comment:
NIT: should we move this to a static block of the class to avoid issues like caller forget to invoke setConfiguration explicitly?
static {
addDeprecations();
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel commented on a change in pull request
#689: HDDS-3183. Deprecate old Recon HTTP Server Keytab config key.
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on a change in pull request #689: HDDS-3183. Deprecate old Recon HTTP Server Keytab config key.
URL: https://github.com/apache/hadoop-ozone/pull/689#discussion_r394690824
##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ConfigurationProvider.java
##########
@@ -32,10 +33,17 @@
private static OzoneConfiguration configuration;
+ private static void addDeprecations() {
+ Configuration.addDeprecation(
+ ReconServerConfigKeys.OZONE_RECON_HTTP_KEYTAB_FILE_OLD,
+ ReconServerConfigKeys.OZONE_RECON_HTTP_KEYTAB_FILE);
+ }
+
@VisibleForTesting
public static void setConfiguration(OzoneConfiguration conf) {
if (configuration == null) {
ConfigurationProvider.configuration = conf;
+ ConfigurationProvider.addDeprecations();
Review comment:
Good suggestion! I have fixed it in the latest commit. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel commented on issue #689: HDDS-3183.
Deprecate old Recon HTTP Server Keytab config key.
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on issue #689: HDDS-3183. Deprecate old Recon HTTP Server Keytab config key.
URL: https://github.com/apache/hadoop-ozone/pull/689#issuecomment-599637201
@avijayanhwx Please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] avijayanhwx commented on issue #689: HDDS-3183.
Deprecate old Recon HTTP Server Keytab config key.
Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on issue #689: HDDS-3183. Deprecate old Recon HTTP Server Keytab config key.
URL: https://github.com/apache/hadoop-ozone/pull/689#issuecomment-600932675
Thank you for the patch @vivekratnavel & the review @xiaoyuyao.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel commented on issue #689: HDDS-3183.
Deprecate old Recon HTTP Server Keytab config key.
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on issue #689: HDDS-3183. Deprecate old Recon HTTP Server Keytab config key.
URL: https://github.com/apache/hadoop-ozone/pull/689#issuecomment-600933732
Thank you @avijayanhwx and @xiaoyuyao for the reviews!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request
#689: HDDS-3183. Deprecate old Recon HTTP Server Keytab config key.
Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on a change in pull request #689: HDDS-3183. Deprecate old Recon HTTP Server Keytab config key.
URL: https://github.com/apache/hadoop-ozone/pull/689#discussion_r393192877
##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconServer.java
##########
@@ -66,6 +67,9 @@ public static void main(String[] args) {
@Override
public Void call() throws Exception {
OzoneConfiguration ozoneConfiguration = createOzoneConfiguration();
+ Configuration.addDeprecation(
+ ReconServerConfigKeys.OZONE_RECON_HTTP_KEYTAB_FILE_OLD,
Review comment:
Maybe we can add a method 'addConfigurationOverrides' in the ConfigurationProvider provider and move this logic there? When we have more deprecated keys in the future, it may be easier to maintain them there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org