You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Jordan Ly <jo...@gmail.com> on 2018/03/05 00:48:03 UTC
Review Request 65896: Persist scheduler/observer logs to
/var/log/aurora/[FILE].log
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65896/
-----------------------------------------------------------
Review request for Aurora, Renan DelValle and Santhosh Kumar Shanmugham.
Repository: aurora
Description
-------
Persist scheduler/observer logs to /var/log/aurora/[FILE].log
`journalctl -u aurora-[executor|scheduler]` still works.
I also added a TODO to rename the `aurora-executor.service` file to `aurora-observer.service` since it is not correctly named. I think this might require a modification to the base image which I may do at a later point in time.
Diffs
-----
docs/getting-started/vagrant.md 73d0affaa6cc9a31781dce54b4c05a1686d35b01
examples/vagrant/provision-dev-cluster.sh 4a023907b57a6912936533c6d45a25fc929bbab8
examples/vagrant/systemd/aurora-executor.service 5a1a9082ecd7b1367ec677d760a5c375b6db9076
examples/vagrant/systemd/aurora-scheduler-kerberos.service 1c2cfc4c8edd3f66675d843ef8a6518e2916bc63
examples/vagrant/systemd/aurora-scheduler.service 524cbb3b028b45157bcc082756f48a531c52ced3
Diff: https://reviews.apache.org/r/65896/diff/1/
Testing
-------
Manually tested that logs were created on vagrant.
```
vagrant@aurora:~$ ls /var/log/aurora/
observer.log scheduler.log
vagrant@aurora:~$ tail -3 /var/log/aurora/scheduler.log
Mar 5 00:44:13 aurora aurora-scheduler[3609]: I0305 00:44:13.441440 3722 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
Mar 5 00:44:28 aurora aurora-scheduler[3609]: I0305 00:44:28.442432 3727 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
Mar 5 00:44:43 aurora aurora-scheduler[3609]: I0305 00:44:43.444105 3726 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
vagrant@aurora:~$ journalctl -u aurora-scheduler | tail -3
Mar 05 00:44:28 aurora aurora-scheduler[3609]: I0305 00:44:28.442432 3727 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
Mar 05 00:44:43 aurora aurora-scheduler[3609]: I0305 00:44:43.444105 3726 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
Mar 05 00:44:58 aurora aurora-scheduler[3609]: I0305 00:44:58.444711 3729 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
vagrant@aurora:~$ tail -3 /var/log/aurora/observer.log
Mar 5 00:36:18 aurora aurora-observer[3129]: Bottle v0.11.6 server starting up (using CherryPyServer())...
Mar 5 00:36:18 aurora aurora-observer[3129]: Listening on http://192.168.33.7:1338/
Mar 5 00:36:18 aurora aurora-observer[3129]: Hit Ctrl-C to quit.
vagrant@aurora:~$ journalctl -u aurora-executor | tail -3
Mar 05 00:36:18 aurora aurora-observer[3129]: Bottle v0.11.6 server starting up (using CherryPyServer())...
Mar 05 00:36:18 aurora aurora-observer[3129]: Listening on http://192.168.33.7:1338/
Mar 05 00:36:18 aurora aurora-observer[3129]: Hit Ctrl-C to quit.
```
Thanks,
Jordan Ly
Re: Review Request 65896: Persist scheduler/observer logs to
/var/log/aurora/[FILE].log
Posted by Renan DelValle <re...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65896/#review198634
-----------------------------------------------------------
Can we also open a jira ticket to change this in our aurora-packing repo? Ideally our vagrant setup should mirror the way our binary distributions work for the distro the vagrant image is based on to avoid confusion.
docs/getting-started/vagrant.md
Line 151 (original), 151 (patched)
<https://reviews.apache.org/r/65896/#comment278874>
Can we put both as options here?
examples/vagrant/systemd/aurora-executor.service
Lines 13 (patched)
<https://reviews.apache.org/r/65896/#comment278873>
This was a mistake on my part. This should actually be named `thermos.service` to match our Ubuntu Xenial binary distribution.
I'd be ok with changing to `aurora-thermos-observer.service` or something along those lines but it would have to be done across all our binary distributions and should include a stern warning in the release notes so folks that depend on automated tooling can adjust.
So for this patch I vote for renaming this `aurora-exeutor.service` to `thermos.service` and then we can open a jira ticket to track the change to something more descriptive.
- Renan DelValle
On March 4, 2018, 4:48 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65896/
> -----------------------------------------------------------
>
> (Updated March 4, 2018, 4:48 p.m.)
>
>
> Review request for Aurora, Renan DelValle and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Persist scheduler/observer logs to /var/log/aurora/[FILE].log
>
> `journalctl -u aurora-[executor|scheduler]` still works.
>
> I also added a TODO to rename the `aurora-executor.service` file to `aurora-observer.service` since it is not correctly named. I think this might require a modification to the base image which I may do at a later point in time.
>
>
> Diffs
> -----
>
> docs/getting-started/vagrant.md 73d0affaa6cc9a31781dce54b4c05a1686d35b01
> examples/vagrant/provision-dev-cluster.sh 4a023907b57a6912936533c6d45a25fc929bbab8
> examples/vagrant/systemd/aurora-executor.service 5a1a9082ecd7b1367ec677d760a5c375b6db9076
> examples/vagrant/systemd/aurora-scheduler-kerberos.service 1c2cfc4c8edd3f66675d843ef8a6518e2916bc63
> examples/vagrant/systemd/aurora-scheduler.service 524cbb3b028b45157bcc082756f48a531c52ced3
>
>
> Diff: https://reviews.apache.org/r/65896/diff/1/
>
>
> Testing
> -------
>
> Manually tested that logs were created on vagrant.
>
> ```
> vagrant@aurora:~$ ls /var/log/aurora/
> observer.log scheduler.log
> vagrant@aurora:~$ tail -3 /var/log/aurora/scheduler.log
> Mar 5 00:44:13 aurora aurora-scheduler[3609]: I0305 00:44:13.441440 3722 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> Mar 5 00:44:28 aurora aurora-scheduler[3609]: I0305 00:44:28.442432 3727 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> Mar 5 00:44:43 aurora aurora-scheduler[3609]: I0305 00:44:43.444105 3726 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> vagrant@aurora:~$ journalctl -u aurora-scheduler | tail -3
> Mar 05 00:44:28 aurora aurora-scheduler[3609]: I0305 00:44:28.442432 3727 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> Mar 05 00:44:43 aurora aurora-scheduler[3609]: I0305 00:44:43.444105 3726 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> Mar 05 00:44:58 aurora aurora-scheduler[3609]: I0305 00:44:58.444711 3729 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> vagrant@aurora:~$ tail -3 /var/log/aurora/observer.log
> Mar 5 00:36:18 aurora aurora-observer[3129]: Bottle v0.11.6 server starting up (using CherryPyServer())...
> Mar 5 00:36:18 aurora aurora-observer[3129]: Listening on http://192.168.33.7:1338/
> Mar 5 00:36:18 aurora aurora-observer[3129]: Hit Ctrl-C to quit.
> vagrant@aurora:~$ journalctl -u aurora-executor | tail -3
> Mar 05 00:36:18 aurora aurora-observer[3129]: Bottle v0.11.6 server starting up (using CherryPyServer())...
> Mar 05 00:36:18 aurora aurora-observer[3129]: Listening on http://192.168.33.7:1338/
> Mar 05 00:36:18 aurora aurora-observer[3129]: Hit Ctrl-C to quit.
> ```
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 65896: Persist scheduler/observer logs to
/var/log/aurora/[FILE].log
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65896/#review199434
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Kumar Shanmugham
On March 14, 2018, 3:23 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65896/
> -----------------------------------------------------------
>
> (Updated March 14, 2018, 3:23 p.m.)
>
>
> Review request for Aurora, Renan DelValle and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Persist scheduler/observer logs to /var/log/aurora/[FILE].log
>
> `journalctl -u aurora-[executor|scheduler]` still works.
>
>
> Diffs
> -----
>
> docs/getting-started/vagrant.md 73d0affaa6cc9a31781dce54b4c05a1686d35b01
> examples/vagrant/aurorabuild.sh 5eb1822a7940abcf58903d5c60a1f004cf2439c9
> examples/vagrant/provision-dev-cluster.sh 4a023907b57a6912936533c6d45a25fc929bbab8
> examples/vagrant/systemd/aurora-executor.service 5a1a9082ecd7b1367ec677d760a5c375b6db9076
> examples/vagrant/systemd/aurora-scheduler-kerberos.service 1c2cfc4c8edd3f66675d843ef8a6518e2916bc63
> examples/vagrant/systemd/aurora-scheduler.service 524cbb3b028b45157bcc082756f48a531c52ced3
>
>
> Diff: https://reviews.apache.org/r/65896/diff/2/
>
>
> Testing
> -------
>
> Manually tested that logs were created on vagrant.
>
> ```
> vagrant@aurora:~$ ls /var/log/aurora/
> observer.log scheduler.log
> vagrant@aurora:~$ tail -3 /var/log/aurora/scheduler.log
> Mar 5 00:44:13 aurora aurora-scheduler[3609]: I0305 00:44:13.441440 3722 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> Mar 5 00:44:28 aurora aurora-scheduler[3609]: I0305 00:44:28.442432 3727 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> Mar 5 00:44:43 aurora aurora-scheduler[3609]: I0305 00:44:43.444105 3726 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> vagrant@aurora:~$ journalctl -u aurora-scheduler | tail -3
> Mar 05 00:44:28 aurora aurora-scheduler[3609]: I0305 00:44:28.442432 3727 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> Mar 05 00:44:43 aurora aurora-scheduler[3609]: I0305 00:44:43.444105 3726 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> Mar 05 00:44:58 aurora aurora-scheduler[3609]: I0305 00:44:58.444711 3729 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> vagrant@aurora:~$ tail -3 /var/log/aurora/observer.log
> Mar 5 00:36:18 aurora aurora-observer[3129]: Bottle v0.11.6 server starting up (using CherryPyServer())...
> Mar 5 00:36:18 aurora aurora-observer[3129]: Listening on http://192.168.33.7:1338/
> Mar 5 00:36:18 aurora aurora-observer[3129]: Hit Ctrl-C to quit.
> vagrant@aurora:~$ journalctl -u aurora-executor | tail -3
> Mar 05 00:36:18 aurora aurora-observer[3129]: Bottle v0.11.6 server starting up (using CherryPyServer())...
> Mar 05 00:36:18 aurora aurora-observer[3129]: Listening on http://192.168.33.7:1338/
> Mar 05 00:36:18 aurora aurora-observer[3129]: Hit Ctrl-C to quit.
> ```
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 65896: Persist scheduler/observer logs to
/var/log/aurora/[FILE].log
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65896/#review199220
-----------------------------------------------------------
Ship it!
Master (a12b844) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 14, 2018, 10:23 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65896/
> -----------------------------------------------------------
>
> (Updated March 14, 2018, 10:23 p.m.)
>
>
> Review request for Aurora, Renan DelValle and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Persist scheduler/observer logs to /var/log/aurora/[FILE].log
>
> `journalctl -u aurora-[executor|scheduler]` still works.
>
> I also added a TODO to rename the `aurora-executor.service` file to `aurora-observer.service` since it is not correctly named. I think this might require a modification to the base image which I may do at a later point in time.
>
>
> Diffs
> -----
>
> docs/getting-started/vagrant.md 73d0affaa6cc9a31781dce54b4c05a1686d35b01
> examples/vagrant/aurorabuild.sh 5eb1822a7940abcf58903d5c60a1f004cf2439c9
> examples/vagrant/provision-dev-cluster.sh 4a023907b57a6912936533c6d45a25fc929bbab8
> examples/vagrant/systemd/aurora-executor.service 5a1a9082ecd7b1367ec677d760a5c375b6db9076
> examples/vagrant/systemd/aurora-scheduler-kerberos.service 1c2cfc4c8edd3f66675d843ef8a6518e2916bc63
> examples/vagrant/systemd/aurora-scheduler.service 524cbb3b028b45157bcc082756f48a531c52ced3
>
>
> Diff: https://reviews.apache.org/r/65896/diff/2/
>
>
> Testing
> -------
>
> Manually tested that logs were created on vagrant.
>
> ```
> vagrant@aurora:~$ ls /var/log/aurora/
> observer.log scheduler.log
> vagrant@aurora:~$ tail -3 /var/log/aurora/scheduler.log
> Mar 5 00:44:13 aurora aurora-scheduler[3609]: I0305 00:44:13.441440 3722 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> Mar 5 00:44:28 aurora aurora-scheduler[3609]: I0305 00:44:28.442432 3727 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> Mar 5 00:44:43 aurora aurora-scheduler[3609]: I0305 00:44:43.444105 3726 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> vagrant@aurora:~$ journalctl -u aurora-scheduler | tail -3
> Mar 05 00:44:28 aurora aurora-scheduler[3609]: I0305 00:44:28.442432 3727 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> Mar 05 00:44:43 aurora aurora-scheduler[3609]: I0305 00:44:43.444105 3726 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> Mar 05 00:44:58 aurora aurora-scheduler[3609]: I0305 00:44:58.444711 3729 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> vagrant@aurora:~$ tail -3 /var/log/aurora/observer.log
> Mar 5 00:36:18 aurora aurora-observer[3129]: Bottle v0.11.6 server starting up (using CherryPyServer())...
> Mar 5 00:36:18 aurora aurora-observer[3129]: Listening on http://192.168.33.7:1338/
> Mar 5 00:36:18 aurora aurora-observer[3129]: Hit Ctrl-C to quit.
> vagrant@aurora:~$ journalctl -u aurora-executor | tail -3
> Mar 05 00:36:18 aurora aurora-observer[3129]: Bottle v0.11.6 server starting up (using CherryPyServer())...
> Mar 05 00:36:18 aurora aurora-observer[3129]: Listening on http://192.168.33.7:1338/
> Mar 05 00:36:18 aurora aurora-observer[3129]: Hit Ctrl-C to quit.
> ```
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 65896: Persist scheduler/observer logs to
/var/log/aurora/[FILE].log
Posted by Renan DelValle <re...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65896/#review199331
-----------------------------------------------------------
Ship it!
Ship It!
- Renan DelValle
On March 14, 2018, 3:23 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65896/
> -----------------------------------------------------------
>
> (Updated March 14, 2018, 3:23 p.m.)
>
>
> Review request for Aurora, Renan DelValle and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Persist scheduler/observer logs to /var/log/aurora/[FILE].log
>
> `journalctl -u aurora-[executor|scheduler]` still works.
>
> I also added a TODO to rename the `aurora-executor.service` file to `aurora-observer.service` since it is not correctly named. I think this might require a modification to the base image which I may do at a later point in time.
>
>
> Diffs
> -----
>
> docs/getting-started/vagrant.md 73d0affaa6cc9a31781dce54b4c05a1686d35b01
> examples/vagrant/aurorabuild.sh 5eb1822a7940abcf58903d5c60a1f004cf2439c9
> examples/vagrant/provision-dev-cluster.sh 4a023907b57a6912936533c6d45a25fc929bbab8
> examples/vagrant/systemd/aurora-executor.service 5a1a9082ecd7b1367ec677d760a5c375b6db9076
> examples/vagrant/systemd/aurora-scheduler-kerberos.service 1c2cfc4c8edd3f66675d843ef8a6518e2916bc63
> examples/vagrant/systemd/aurora-scheduler.service 524cbb3b028b45157bcc082756f48a531c52ced3
>
>
> Diff: https://reviews.apache.org/r/65896/diff/2/
>
>
> Testing
> -------
>
> Manually tested that logs were created on vagrant.
>
> ```
> vagrant@aurora:~$ ls /var/log/aurora/
> observer.log scheduler.log
> vagrant@aurora:~$ tail -3 /var/log/aurora/scheduler.log
> Mar 5 00:44:13 aurora aurora-scheduler[3609]: I0305 00:44:13.441440 3722 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> Mar 5 00:44:28 aurora aurora-scheduler[3609]: I0305 00:44:28.442432 3727 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> Mar 5 00:44:43 aurora aurora-scheduler[3609]: I0305 00:44:43.444105 3726 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> vagrant@aurora:~$ journalctl -u aurora-scheduler | tail -3
> Mar 05 00:44:28 aurora aurora-scheduler[3609]: I0305 00:44:28.442432 3727 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> Mar 05 00:44:43 aurora aurora-scheduler[3609]: I0305 00:44:43.444105 3726 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> Mar 05 00:44:58 aurora aurora-scheduler[3609]: I0305 00:44:58.444711 3729 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> vagrant@aurora:~$ tail -3 /var/log/aurora/observer.log
> Mar 5 00:36:18 aurora aurora-observer[3129]: Bottle v0.11.6 server starting up (using CherryPyServer())...
> Mar 5 00:36:18 aurora aurora-observer[3129]: Listening on http://192.168.33.7:1338/
> Mar 5 00:36:18 aurora aurora-observer[3129]: Hit Ctrl-C to quit.
> vagrant@aurora:~$ journalctl -u aurora-executor | tail -3
> Mar 05 00:36:18 aurora aurora-observer[3129]: Bottle v0.11.6 server starting up (using CherryPyServer())...
> Mar 05 00:36:18 aurora aurora-observer[3129]: Listening on http://192.168.33.7:1338/
> Mar 05 00:36:18 aurora aurora-observer[3129]: Hit Ctrl-C to quit.
> ```
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 65896: Persist scheduler/observer logs to
/var/log/aurora/[FILE].log
Posted by Jordan Ly <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65896/
-----------------------------------------------------------
(Updated March 14, 2018, 10:23 p.m.)
Review request for Aurora, Renan DelValle and Santhosh Kumar Shanmugham.
Changes
-------
Added both options of getting logs into `vagrant.md`
Renamed aurora -> thermos when referencing the observer.
Repository: aurora
Description
-------
Persist scheduler/observer logs to /var/log/aurora/[FILE].log
`journalctl -u aurora-[executor|scheduler]` still works.
I also added a TODO to rename the `aurora-executor.service` file to `aurora-observer.service` since it is not correctly named. I think this might require a modification to the base image which I may do at a later point in time.
Diffs (updated)
-----
docs/getting-started/vagrant.md 73d0affaa6cc9a31781dce54b4c05a1686d35b01
examples/vagrant/aurorabuild.sh 5eb1822a7940abcf58903d5c60a1f004cf2439c9
examples/vagrant/provision-dev-cluster.sh 4a023907b57a6912936533c6d45a25fc929bbab8
examples/vagrant/systemd/aurora-executor.service 5a1a9082ecd7b1367ec677d760a5c375b6db9076
examples/vagrant/systemd/aurora-scheduler-kerberos.service 1c2cfc4c8edd3f66675d843ef8a6518e2916bc63
examples/vagrant/systemd/aurora-scheduler.service 524cbb3b028b45157bcc082756f48a531c52ced3
Diff: https://reviews.apache.org/r/65896/diff/2/
Changes: https://reviews.apache.org/r/65896/diff/1-2/
Testing
-------
Manually tested that logs were created on vagrant.
```
vagrant@aurora:~$ ls /var/log/aurora/
observer.log scheduler.log
vagrant@aurora:~$ tail -3 /var/log/aurora/scheduler.log
Mar 5 00:44:13 aurora aurora-scheduler[3609]: I0305 00:44:13.441440 3722 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
Mar 5 00:44:28 aurora aurora-scheduler[3609]: I0305 00:44:28.442432 3727 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
Mar 5 00:44:43 aurora aurora-scheduler[3609]: I0305 00:44:43.444105 3726 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
vagrant@aurora:~$ journalctl -u aurora-scheduler | tail -3
Mar 05 00:44:28 aurora aurora-scheduler[3609]: I0305 00:44:28.442432 3727 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
Mar 05 00:44:43 aurora aurora-scheduler[3609]: I0305 00:44:43.444105 3726 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
Mar 05 00:44:58 aurora aurora-scheduler[3609]: I0305 00:44:58.444711 3729 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
vagrant@aurora:~$ tail -3 /var/log/aurora/observer.log
Mar 5 00:36:18 aurora aurora-observer[3129]: Bottle v0.11.6 server starting up (using CherryPyServer())...
Mar 5 00:36:18 aurora aurora-observer[3129]: Listening on http://192.168.33.7:1338/
Mar 5 00:36:18 aurora aurora-observer[3129]: Hit Ctrl-C to quit.
vagrant@aurora:~$ journalctl -u aurora-executor | tail -3
Mar 05 00:36:18 aurora aurora-observer[3129]: Bottle v0.11.6 server starting up (using CherryPyServer())...
Mar 05 00:36:18 aurora aurora-observer[3129]: Listening on http://192.168.33.7:1338/
Mar 05 00:36:18 aurora aurora-observer[3129]: Hit Ctrl-C to quit.
```
Thanks,
Jordan Ly
Re: Review Request 65896: Persist scheduler/observer logs to
/var/log/aurora/[FILE].log
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65896/#review198609
-----------------------------------------------------------
Fix it, then Ship it!
docs/getting-started/vagrant.md
Line 152 (original), 152 (patched)
<https://reviews.apache.org/r/65896/#comment278846>
s/aurora/thermos/
examples/vagrant/provision-dev-cluster.sh
Lines 50 (patched)
<https://reviews.apache.org/r/65896/#comment278848>
s/aurora/thermos/
examples/vagrant/provision-dev-cluster.sh
Lines 51 (patched)
<https://reviews.apache.org/r/65896/#comment278847>
s/aurora/thermos/
examples/vagrant/systemd/aurora-executor.service
Lines 21 (patched)
<https://reviews.apache.org/r/65896/#comment278849>
s/aurora/thermos/
- Santhosh Kumar Shanmugham
On March 4, 2018, 4:48 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65896/
> -----------------------------------------------------------
>
> (Updated March 4, 2018, 4:48 p.m.)
>
>
> Review request for Aurora, Renan DelValle and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Persist scheduler/observer logs to /var/log/aurora/[FILE].log
>
> `journalctl -u aurora-[executor|scheduler]` still works.
>
> I also added a TODO to rename the `aurora-executor.service` file to `aurora-observer.service` since it is not correctly named. I think this might require a modification to the base image which I may do at a later point in time.
>
>
> Diffs
> -----
>
> docs/getting-started/vagrant.md 73d0affaa6cc9a31781dce54b4c05a1686d35b01
> examples/vagrant/provision-dev-cluster.sh 4a023907b57a6912936533c6d45a25fc929bbab8
> examples/vagrant/systemd/aurora-executor.service 5a1a9082ecd7b1367ec677d760a5c375b6db9076
> examples/vagrant/systemd/aurora-scheduler-kerberos.service 1c2cfc4c8edd3f66675d843ef8a6518e2916bc63
> examples/vagrant/systemd/aurora-scheduler.service 524cbb3b028b45157bcc082756f48a531c52ced3
>
>
> Diff: https://reviews.apache.org/r/65896/diff/1/
>
>
> Testing
> -------
>
> Manually tested that logs were created on vagrant.
>
> ```
> vagrant@aurora:~$ ls /var/log/aurora/
> observer.log scheduler.log
> vagrant@aurora:~$ tail -3 /var/log/aurora/scheduler.log
> Mar 5 00:44:13 aurora aurora-scheduler[3609]: I0305 00:44:13.441440 3722 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> Mar 5 00:44:28 aurora aurora-scheduler[3609]: I0305 00:44:28.442432 3727 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> Mar 5 00:44:43 aurora aurora-scheduler[3609]: I0305 00:44:43.444105 3726 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> vagrant@aurora:~$ journalctl -u aurora-scheduler | tail -3
> Mar 05 00:44:28 aurora aurora-scheduler[3609]: I0305 00:44:28.442432 3727 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> Mar 05 00:44:43 aurora aurora-scheduler[3609]: I0305 00:44:43.444105 3726 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> Mar 05 00:44:58 aurora aurora-scheduler[3609]: I0305 00:44:58.444711 3729 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> vagrant@aurora:~$ tail -3 /var/log/aurora/observer.log
> Mar 5 00:36:18 aurora aurora-observer[3129]: Bottle v0.11.6 server starting up (using CherryPyServer())...
> Mar 5 00:36:18 aurora aurora-observer[3129]: Listening on http://192.168.33.7:1338/
> Mar 5 00:36:18 aurora aurora-observer[3129]: Hit Ctrl-C to quit.
> vagrant@aurora:~$ journalctl -u aurora-executor | tail -3
> Mar 05 00:36:18 aurora aurora-observer[3129]: Bottle v0.11.6 server starting up (using CherryPyServer())...
> Mar 05 00:36:18 aurora aurora-observer[3129]: Listening on http://192.168.33.7:1338/
> Mar 05 00:36:18 aurora aurora-observer[3129]: Hit Ctrl-C to quit.
> ```
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 65896: Persist scheduler/observer logs to
/var/log/aurora/[FILE].log
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65896/#review198605
-----------------------------------------------------------
Ship it!
Master (a12b844) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 5, 2018, 12:48 a.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65896/
> -----------------------------------------------------------
>
> (Updated March 5, 2018, 12:48 a.m.)
>
>
> Review request for Aurora, Renan DelValle and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Persist scheduler/observer logs to /var/log/aurora/[FILE].log
>
> `journalctl -u aurora-[executor|scheduler]` still works.
>
> I also added a TODO to rename the `aurora-executor.service` file to `aurora-observer.service` since it is not correctly named. I think this might require a modification to the base image which I may do at a later point in time.
>
>
> Diffs
> -----
>
> docs/getting-started/vagrant.md 73d0affaa6cc9a31781dce54b4c05a1686d35b01
> examples/vagrant/provision-dev-cluster.sh 4a023907b57a6912936533c6d45a25fc929bbab8
> examples/vagrant/systemd/aurora-executor.service 5a1a9082ecd7b1367ec677d760a5c375b6db9076
> examples/vagrant/systemd/aurora-scheduler-kerberos.service 1c2cfc4c8edd3f66675d843ef8a6518e2916bc63
> examples/vagrant/systemd/aurora-scheduler.service 524cbb3b028b45157bcc082756f48a531c52ced3
>
>
> Diff: https://reviews.apache.org/r/65896/diff/1/
>
>
> Testing
> -------
>
> Manually tested that logs were created on vagrant.
>
> ```
> vagrant@aurora:~$ ls /var/log/aurora/
> observer.log scheduler.log
> vagrant@aurora:~$ tail -3 /var/log/aurora/scheduler.log
> Mar 5 00:44:13 aurora aurora-scheduler[3609]: I0305 00:44:13.441440 3722 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> Mar 5 00:44:28 aurora aurora-scheduler[3609]: I0305 00:44:28.442432 3727 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> Mar 5 00:44:43 aurora aurora-scheduler[3609]: I0305 00:44:43.444105 3726 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> vagrant@aurora:~$ journalctl -u aurora-scheduler | tail -3
> Mar 05 00:44:28 aurora aurora-scheduler[3609]: I0305 00:44:28.442432 3727 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> Mar 05 00:44:43 aurora aurora-scheduler[3609]: I0305 00:44:43.444105 3726 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> Mar 05 00:44:58 aurora aurora-scheduler[3609]: I0305 00:44:58.444711 3729 scheduler.cpp:676] Enqueuing event HEARTBEAT received from http://192.168.33.7:5050/master/api/v1/scheduler
> vagrant@aurora:~$ tail -3 /var/log/aurora/observer.log
> Mar 5 00:36:18 aurora aurora-observer[3129]: Bottle v0.11.6 server starting up (using CherryPyServer())...
> Mar 5 00:36:18 aurora aurora-observer[3129]: Listening on http://192.168.33.7:1338/
> Mar 5 00:36:18 aurora aurora-observer[3129]: Hit Ctrl-C to quit.
> vagrant@aurora:~$ journalctl -u aurora-executor | tail -3
> Mar 05 00:36:18 aurora aurora-observer[3129]: Bottle v0.11.6 server starting up (using CherryPyServer())...
> Mar 05 00:36:18 aurora aurora-observer[3129]: Listening on http://192.168.33.7:1338/
> Mar 05 00:36:18 aurora aurora-observer[3129]: Hit Ctrl-C to quit.
> ```
>
>
> Thanks,
>
> Jordan Ly
>
>