You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "bjornjorgensen (via GitHub)" <gi...@apache.org> on 2023/03/21 08:52:54 UTC

[GitHub] [spark] bjornjorgensen commented on a diff in pull request #40408: [SPARK-42780][BUILD] Upgrade `Tink` to 1.8.0

bjornjorgensen commented on code in PR #40408:
URL: https://github.com/apache/spark/pull/40408#discussion_r1143050156


##########
pom.xml:
##########
@@ -214,7 +214,7 @@
     <commons-crypto.version>1.1.0</commons-crypto.version>
     <commons-cli.version>1.5.0</commons-cli.version>
     <bouncycastle.version>1.60</bouncycastle.version>
-    <tink.version>1.7.0</tink.version>
+    <tink.version>1.8.0</tink.version>

Review Comment:
   yes, there may be a way to do it. I see that maybe they have a fix for this https://github.com/tink-crypto/tink-java/commit/5733ab346c95eac6840bff23e050a1e16749e928 . Considering the KISS principle, I'm waiting for a new release. It can get a bit complicated if we need to troubleshoot.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org