[GitHub] [beam] damccorm commented on a diff in pull request #17663: [BEAM-14469] Reduce the number of zero-length restrictions produced in TestCheckpointing

[GitBox <gi...@apache.org>]

damccorm commented on code in PR #17663:
URL: https://github.com/apache/beam/pull/17663#discussion_r872563185


##########
sdks/go/test/integration/primitives/checkpointing.go:
##########
@@ -57,7 +57,9 @@ func (fn *selfCheckpointingDoFn) SplitRestriction(_ []byte, rest offsetrange.Res
 	s := rest.Start
 	var splits []offsetrange.Restriction
 	for e := s + size; e <= rest.End; s, e = e, e+size {
-		splits = append(splits, offsetrange.Restriction{Start: s, End: e})
+		if s != e {

Review Comment:
   Isn't it impossible for `s` to equal `e`? Won't `e` always equal `s + size`, with `size` always equaling 1?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org