You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2019/08/17 12:10:35 UTC
[GitHub] [groovy] danielsun1106 commented on a change in pull request #996:
Fix potential bugs
danielsun1106 commented on a change in pull request #996: Fix potential bugs
URL: https://github.com/apache/groovy/pull/996#discussion_r314945226
##########
File path: src/main/java/groovy/lang/ExpandoMetaClass.java
##########
@@ -477,11 +477,11 @@ public static void disableGlobally() {
ExpandoMetaClassCreationHandle.disable();
}
- /* (non-Javadoc)
- * @see groovy.lang.MetaClassImpl#initialize()
+ /**
+ * {@inheritDoc}
*/
-
- public void initialize() {
+ @Override
+ public synchronized void initialize() {
try {
Review comment:
The method implements synchronization via ` lock` API, the `synchronized` seems redundant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services